public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 lib/metadata/thin_manip.c libdm/libdm-dep ... Date: Wed, 19 Oct 2011 16:42:00 -0000 [thread overview] Message-ID: <20111019164215.636.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-19 16:42:14 Modified files: lib/metadata : thin_manip.c libdm : libdm-deptree.c Log message: Update error message Drop INTERNAL_ERROR from public API functions. Improve some messages. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/thin_manip.c.diff?cvsroot=lvm2&r1=1.11&r2=1.12 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.131&r2=1.132 --- LVM2/lib/metadata/thin_manip.c 2011/10/19 16:39:09 1.11 +++ LVM2/lib/metadata/thin_manip.c 2011/10/19 16:42:14 1.12 @@ -126,7 +126,7 @@ tmsg->u.delete_id = delete_id; break; default: - log_error(INTERNAL_ERROR "Unsupported message type %d", type); + log_error(INTERNAL_ERROR "Unsupported message type %u.", type); return 0; } --- LVM2/libdm/libdm-deptree.c 2011/10/19 16:40:59 1.131 +++ LVM2/libdm/libdm-deptree.c 2011/10/19 16:42:14 1.132 @@ -2880,13 +2880,13 @@ struct thin_message *tm; if (node->props.segment_count != 1) { - log_error(INTERNAL_ERROR "Attempt to use non thin pool segment."); + log_error("Thin pool node must have only one segment."); return 0; } seg = dm_list_item(dm_list_last(&node->props.segs), struct load_segment); if (seg->type != SEG_THIN_POOL) { - log_error(INTERNAL_ERROR "Attempt to use non thin pool segment %s.", + log_error("Thin pool node has segment type %s.", dm_segtypes[seg->type].target); return 0; } @@ -2898,9 +2898,9 @@ switch (message->type) { case DM_THIN_MESSAGE_CREATE_SNAP: - /* Origin MUST be suspend! */ + /* If the thin origin is active, it must be suspend first! */ if (message->u.m_create_snap.device_id == message->u.m_create_snap.origin_id) { - log_error("Same origin used for thin snapshot."); + log_error("Cannot use same device id for origin and its snapshot."); return 0; } if (!_thin_validate_device_id(message->u.m_create_snap.device_id) ||
next reply other threads:[~2011-10-19 16:42 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-19 16:42 zkabelac [this message] 2011-10-30 22:52 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111019164215.636.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).