From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30969 invoked by alias); 28 Oct 2011 20:17:59 -0000 Received: (qmail 30830 invoked by uid 9737); 28 Oct 2011 20:17:56 -0000 Date: Fri, 28 Oct 2011 20:17:00 -0000 Message-ID: <20111028201756.30828.qmail@sourceware.org> From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/lv_manip.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00114.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-28 20:17:56 Modified files: . : WHATS_NEW lib/metadata : lv_manip.c Log message: Extend virtual segment instead of adding new one Before adding a new virtual segment to LV, check first whether the last segment isn't already of the same type. In this case extend last segment instead of creating the new one. Thin volumes should have always only 1 virtual segment, but it helps also to virtual snapshot or error segtype.. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2174&r2=1.2175 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv_manip.c.diff?cvsroot=lvm2&r1=1.304&r2=1.305 --- LVM2/WHATS_NEW 2011/10/28 20:12:54 1.2174 +++ LVM2/WHATS_NEW 2011/10/28 20:17:55 1.2175 @@ -1,5 +1,6 @@ Version 2.02.89 - ================================== + Increase virtual segment size instead of creating multiple segment list. Add last_seg(lv) internal function. Support empty string for log/prefix. Fix regression that allowed mirrored logs for cluster mirrors. --- LVM2/lib/metadata/lv_manip.c 2011/10/23 16:02:02 1.304 +++ LVM2/lib/metadata/lv_manip.c 2011/10/28 20:17:56 1.305 @@ -2043,20 +2043,23 @@ thin_pool_lv = lvl->lv; } - if (!(seg = alloc_lv_segment(segtype, lv, lv->le_count, extents, - status, 0, NULL, thin_pool_lv, 0, - extents, 0, 0, 0, NULL))) { - log_error("Couldn't allocate new zero segment."); - return 0; + if ((seg = last_seg(lv)) && (seg->segtype == segtype)) { + seg->area_len += extents; + seg->len += extents; + } else { + if (!(seg = alloc_lv_segment(segtype, lv, lv->le_count, extents, + status, 0, NULL, thin_pool_lv, 0, + extents, 0, 0, 0, NULL))) { + log_error("Couldn't allocate new zero segment."); + return 0; + } + lv->status |= VIRTUAL; + dm_list_add(&lv->segments, &seg->list); } - dm_list_add(&lv->segments, &seg->list); - lv->le_count += extents; lv->size += (uint64_t) extents *lv->vg->extent_size; - lv->status |= VIRTUAL; - return 1; }