From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-4676-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 6662 invoked by alias); 28 Oct 2011 20:29:07 -0000
Received: (qmail 6642 invoked by uid 9737); 28 Oct 2011 20:29:07 -0000
Date: Fri, 28 Oct 2011 20:29:00 -0000
Message-ID: <20111028202907.6640.qmail@sourceware.org>
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools lvchange.c vgchange.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00120.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-10-28 20:29:07

Modified files:
	tools          : lvchange.c vgchange.c 

Log message:
	Thin works only with exclusive activation
	
	Enforce exclusive activation with thin targets.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.131&r2=1.132
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.125&r2=1.126

--- LVM2/tools/lvchange.c	2011/10/28 20:28:01	1.131
+++ LVM2/tools/lvchange.c	2011/10/28 20:29:06	1.132
@@ -135,7 +135,9 @@
 		if (!deactivate_lv(cmd, lv))
 			return_0;
 	} else {
-		if (lv_is_origin(lv) || (activate == CHANGE_AE)) {
+		if ((activate == CHANGE_AE) ||
+		    lv_is_origin(lv) ||
+		    lv_is_thin_type(lv)) {
 			log_verbose("Activating logical volume \"%s\" "
 				    "exclusively", lv->name);
 			if (!activate_lv_excl(cmd, lv))
--- LVM2/tools/vgchange.c	2011/10/28 20:28:01	1.125
+++ LVM2/tools/vgchange.c	2011/10/28 20:29:06	1.126
@@ -149,10 +149,10 @@
 				stack;
 				continue;
 			}
-		} else if (lv_is_origin(lv) ||
-			   lv_is_thin_pool(lv) ||
-			   lv_is_thin_volume(lv) ||
-			   (activate == CHANGE_AE)) {
+		} else if ((activate == CHANGE_AE) ||
+			   lv_is_origin(lv) ||
+			   lv_is_thin_type(lv)) {
+			/* FIXME: duplicated test code with lvchange */
 			if (!activate_lv_excl(cmd, lv)) {
 				stack;
 				continue;