public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/metadata lv_manip.c Date: Sun, 30 Oct 2011 22:02:00 -0000 [thread overview] Message-ID: <20111030220218.5633.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-30 22:02:18 Modified files: lib/metadata : lv_manip.c Log message: Cleanup unsuccessfully created thin LV If something fails during creation of thin LV remove such LV and deactivate in case it's been already tried to activate (i.e. thin kernel driver fails for some reason.) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv_manip.c.diff?cvsroot=lvm2&r1=1.314&r2=1.315 --- LVM2/lib/metadata/lv_manip.c 2011/10/30 22:01:39 1.314 +++ LVM2/lib/metadata/lv_manip.c 2011/10/30 22:02:18 1.315 @@ -4150,7 +4150,7 @@ !deactivate_lv(cmd, pool_lv)) { log_error("Failed to deactivate unused pool %s.", pool_lv->name); - return NULL; + goto revert_new_lv; } /* @@ -4159,12 +4159,16 @@ */ if (!(first_seg(lv)->device_id = - get_free_pool_device_id(first_seg(pool_lv)))) - return_NULL; + get_free_pool_device_id(first_seg(pool_lv)))) { + stack; + goto revert_new_lv; + } if (!attach_pool_message(first_seg(pool_lv), - DM_THIN_MESSAGE_CREATE_THIN, lv, 0, 0)) - return_NULL; + DM_THIN_MESSAGE_CREATE_THIN, lv, 0, 0)) { + stack; + goto revert_new_lv; + } } if (lp->log_count && @@ -4194,7 +4198,7 @@ if (!activate_lv_excl(cmd, lv)) { log_error("Aborting. Failed to activate thin %s.", lv->name); - goto revert_new_lv; + goto deactivate_and_revert_new_lv; } } else if (lp->snapshot) { if (!activate_lv_excl(cmd, lv)) {
next reply other threads:[~2011-10-30 22:02 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-30 22:02 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-11 15:32 agk 2012-05-11 15:26 agk 2012-03-04 15:57 zkabelac 2012-03-01 10:09 zkabelac 2012-02-28 10:08 zkabelac 2012-02-12 21:37 agk 2012-02-01 2:11 agk 2012-01-26 21:39 zkabelac 2012-01-25 11:27 zkabelac 2012-01-25 9:15 zkabelac 2012-01-25 9:14 zkabelac 2012-01-25 9:02 zkabelac 2012-01-25 8:57 zkabelac 2012-01-24 14:54 agk 2012-01-24 14:15 mbroz 2012-01-19 15:39 zkabelac 2011-11-15 17:29 zkabelac 2011-11-15 17:23 zkabelac 2011-11-12 22:53 zkabelac 2011-11-12 22:52 zkabelac 2011-11-12 22:51 zkabelac 2011-11-10 12:42 zkabelac 2011-11-10 12:42 zkabelac 2011-11-10 12:39 zkabelac 2011-11-07 13:54 agk 2011-11-04 22:45 zkabelac 2011-11-03 15:46 zkabelac 2011-11-03 14:56 zkabelac 2011-10-28 20:29 zkabelac 2011-10-28 20:18 zkabelac 2011-10-22 16:49 zkabelac 2011-10-22 16:46 zkabelac 2011-10-21 9:55 zkabelac 2011-10-20 10:35 zkabelac 2011-10-03 18:43 zkabelac 2011-09-16 18:39 jbrassow 2011-09-16 12:12 zkabelac 2011-09-16 11:59 zkabelac 2011-09-06 15:39 agk 2011-08-19 22:55 agk 2011-08-19 16:41 agk 2011-08-10 16:44 jbrassow 2011-08-05 9:21 prajnoha 2011-06-06 12:08 agk 2011-03-25 22:02 jbrassow 2010-04-08 0:56 agk 2010-04-08 0:52 agk 2010-04-02 1:35 agk 2010-04-01 13:58 agk 2010-04-01 12:29 agk 2010-03-31 20:26 agk 2010-02-17 23:36 snitzer 2010-01-20 21:53 snitzer 2010-01-14 10:17 zkabelac 2010-01-14 10:09 zkabelac 2010-01-14 10:08 zkabelac 2010-01-13 1:52 snitzer 2010-01-13 1:51 snitzer 2010-01-10 20:44 snitzer 2010-01-08 23:06 jbrassow 2009-06-06 16:37 mbroz 2009-06-01 14:23 mbroz 2009-01-06 17:24 mbroz 2008-01-16 20:00 agk 2007-11-04 16:28 agk 2007-08-08 18:00 wysochanski 2007-08-07 18:55 wysochanski 2007-08-07 16:57 wysochanski 2007-08-06 20:35 wysochanski 2006-10-07 16:00 agk 2006-10-07 11:34 agk 2006-10-07 11:23 agk 2006-04-27 17:58 agk 2005-11-24 21:23 agk 2005-11-24 18:00 agk 2005-10-27 22:20 agk 2005-06-03 15:44 agk 2004-03-19 16:19 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111030220218.5633.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).