public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 lib/metadata/lv_manip.c tools/lvchange.c ... Date: Sun, 30 Oct 2011 22:07:00 -0000 [thread overview] Message-ID: <20111030220739.7780.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-30 22:07:38 Modified files: lib/metadata : lv_manip.c tools : lvchange.c vgchange.c Log message: Thin creation without activation All thins are created with the next activation and VG is updated without messages. Only some basic commands works. (i.e. lvcreate -an -V10 -T mvg/pool) There can be some combination to confuse this system. This functionality for snapshots is going to be interesting. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv_manip.c.diff?cvsroot=lvm2&r1=1.315&r2=1.316 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.132&r2=1.133 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.126&r2=1.127 --- LVM2/lib/metadata/lv_manip.c 2011/10/30 22:02:18 1.315 +++ LVM2/lib/metadata/lv_manip.c 2011/10/30 22:07:38 1.316 @@ -4194,8 +4194,12 @@ init_dmeventd_monitor(lp->activation_monitoring); - if (seg_is_thin_pool(lp) || seg_is_thin(lp)) { - if (!activate_lv_excl(cmd, lv)) { + if (seg_is_thin(lp)) { + if ((lp->activate == CHANGE_AY) || + (lp->activate == CHANGE_ALY)) + lp->activate = CHANGE_AE; + if ((lp->activate == CHANGE_AE) && + !activate_lv_excl(cmd, lv)) { log_error("Aborting. Failed to activate thin %s.", lv->name); goto deactivate_and_revert_new_lv; @@ -4222,7 +4226,7 @@ lp->snapshot ? "snapshot exception store" : "start of new LV"); goto deactivate_and_revert_new_lv; - } else if (seg_is_thin_volume(lp)) { + } else if (seg_is_thin_volume(lp) && (lp->activate == CHANGE_AE)) { /* FIXME: for now we may drop any queued thin messages * since we are sure everything was activated already */ if (!detach_pool_messages(first_seg(lv)->pool_lv)) { --- LVM2/tools/lvchange.c 2011/10/28 20:29:06 1.132 +++ LVM2/tools/lvchange.c 2011/10/30 22:07:38 1.133 @@ -142,6 +142,10 @@ "exclusively", lv->name); if (!activate_lv_excl(cmd, lv)) return_0; + /* Drop any left thin messages after activation */ + if (lv_is_thin_volume(lv) && + !detach_pool_messages(first_seg(lv)->pool_lv)) + return_0; } else if (activate == CHANGE_ALY) { log_verbose("Activating logical volume \"%s\" locally", lv->name); --- LVM2/tools/vgchange.c 2011/10/28 20:29:06 1.126 +++ LVM2/tools/vgchange.c 2011/10/30 22:07:38 1.127 @@ -157,6 +157,12 @@ stack; continue; } + /* Drop any left thin messages after activation */ + if (lv_is_thin_volume(lv) && + !detach_pool_messages(first_seg(lv)->pool_lv)) { + stack; + continue; + } } else if (activate == CHANGE_ALY) { if (!activate_lv_local(cmd, lv)) { stack;
reply other threads:[~2011-10-30 22:07 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111030220739.7780.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).