From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1109 invoked by alias); 3 Nov 2011 14:59:22 -0000 Received: (qmail 1091 invoked by uid 9737); 3 Nov 2011 14:59:21 -0000 Date: Thu, 03 Nov 2011 14:59:00 -0000 Message-ID: <20111103145921.1089.qmail@sourceware.org> From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools lvchange.c toollib.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00010.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-11-03 14:59:20 Modified files: tools : lvchange.c toollib.c Log message: Thin removing limitation on activation of pool device. Since activation of pool is now independent on thin activation, user may do whatever he needs - thought preferable thin should stay alive, but it it will be found inactivate, update_pool will bring the pool up. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.134&r2=1.135 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.232&r2=1.233 --- LVM2/tools/lvchange.c 2011/11/03 14:41:18 1.134 +++ LVM2/tools/lvchange.c 2011/11/03 14:59:20 1.135 @@ -534,12 +534,6 @@ return ECMD_FAILED; } - if (lv_is_used_thin_pool(lv) && - (arg_count(cmd, available_ARG))) { - log_error("Can't change pool volume \"%s\".", lv->name); - return ECMD_FAILED; - } - if (lv_is_cow(lv) && !lv_is_virtual_origin(origin_from_cow(lv)) && arg_count(cmd, available_ARG)) { log_error("Can't change snapshot logical volume \"%s\"", --- LVM2/tools/toollib.c 2011/10/28 20:28:01 1.232 +++ LVM2/tools/toollib.c 2011/11/03 14:59:20 1.233 @@ -126,11 +126,6 @@ if (lv_is_virtual_origin(lvl->lv) && !arg_count(cmd, all_ARG)) continue; - /* Only unused thin pool can change its availability */ - if (!lvargs_supplied && lv_is_used_thin_pool(lvl->lv) && - arg_count(cmd, available_ARG)) - continue; - /* * Only let hidden LVs through it --all was used or the LVs * were specifically named on the command line.