public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/metadata thin_manip.c Date: Mon, 07 Nov 2011 10:59:00 -0000 [thread overview] Message-ID: <20111107105908.9245.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-11-07 10:59:08 Modified files: lib/metadata : thin_manip.c Log message: Thin reindent code Drop indention level Add extra internal error. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/thin_manip.c.diff?cvsroot=lvm2&r1=1.22&r2=1.23 --- LVM2/lib/metadata/thin_manip.c 2011/11/03 15:58:20 1.22 +++ LVM2/lib/metadata/thin_manip.c 2011/11/07 10:59:07 1.23 @@ -88,27 +88,29 @@ struct lv_thin_message *tmsg; dm_list_iterate_items(tmsg, &seg->thin_messages) { - if (tmsg->type == type) { - switch (tmsg->type) { - case DM_THIN_MESSAGE_CREATE_SNAP: - case DM_THIN_MESSAGE_CREATE_THIN: - case DM_THIN_MESSAGE_TRIM: - if (tmsg->u.lv == lv) { - log_error("Message referring LV %s already queued for %s.", - tmsg->u.lv->name, seg->lv->name); - return 0; - } - break; - case DM_THIN_MESSAGE_DELETE: - if (tmsg->u.delete_id == delete_id) { - log_error("Delete of device %u already queued for %s.", - tmsg->u.delete_id, seg->lv->name); - return 0; - } - break; - default: - break; + if (tmsg->type != type) + continue; + + switch (tmsg->type) { + case DM_THIN_MESSAGE_CREATE_SNAP: + case DM_THIN_MESSAGE_CREATE_THIN: + case DM_THIN_MESSAGE_TRIM: + if (tmsg->u.lv == lv) { + log_error("Message referring LV %s already queued for %s.", + tmsg->u.lv->name, seg->lv->name); + return 0; + } + break; + case DM_THIN_MESSAGE_DELETE: + if (tmsg->u.delete_id == delete_id) { + log_error("Delete of device %u already queued for %s.", + tmsg->u.delete_id, seg->lv->name); + return 0; } + break; + default: + log_error(INTERNAL_ERROR "Unsupported message type %u.", tmsg->type); + return 0; } }
next reply other threads:[~2011-11-07 10:59 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-11-07 10:59 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-12 21:42 agk 2012-01-25 9:17 zkabelac 2011-12-10 0:47 agk 2011-11-07 11:04 zkabelac 2011-11-03 15:58 zkabelac 2011-10-19 16:37 zkabelac 2011-10-19 16:32 zkabelac 2011-10-03 19:10 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111107105908.9245.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).