From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-4729-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 6761 invoked by alias); 10 Nov 2011 12:40:30 -0000
Received: (qmail 6744 invoked by uid 9737); 10 Nov 2011 12:40:29 -0000
Date: Thu, 10 Nov 2011 12:40:00 -0000
Message-ID: <20111110124029.6742.qmail@sourceware.org>
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools lvcreate.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00036.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-11-10 12:40:29

Modified files:
	tools          : lvcreate.c 

Log message:
	Thin move _read_activation_params check
	
	Since we finaly recognize thin creation only after
	_determine_snapshot_type() - move _read_activation_params()
	after it - so we can support  lvcreate -an thin snapshot.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.248&r2=1.249

--- LVM2/tools/lvcreate.c	2011/11/10 12:39:46	1.248
+++ LVM2/tools/lvcreate.c	2011/11/10 12:40:29	1.249
@@ -789,9 +789,6 @@
 		return 0;
 	}
 
-	if (!_read_activation_params(lp, cmd))
-		return_0;
-
 	/*
 	 * Allocation parameters
 	 */
@@ -993,6 +990,15 @@
 		goto_out;
 	}
 
+	/*
+	 * Check activation parameters to support inactive thin snapshot creation
+	 * FIXME: anything else needs to be moved past _determine_snapshot_type()?
+	 */
+	if (!_read_activation_params(&lp, cmd)) {
+		r = ECMD_FAILED;
+		goto_out;
+	}
+
 	if (!_update_extents_params(vg, &lp, &lcp)) {
 		r = ECMD_FAILED;
 		goto_out;