public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW lib/metadata/lv.c
Date: Fri, 20 Jan 2012 10:55:00 -0000	[thread overview]
Message-ID: <20120120105529.1867.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2012-01-20 10:55:28

Modified files:
	.              : WHATS_NEW 
	lib/metadata   : lv.c 

Log message:
	Drop hack in segtype reporting
	
	Since striped name function knows when to report 'linear' instead of
	'stripe' type name - drop it from this place.
	
	This fixes problem when reporting segtype e.g. for thin-pool which
	is also using area_count=1 to store thin data device reference.
	
	It also returns properly strduped memory instead of badly casted const char*.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2226&r2=1.2227
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv.c.diff?cvsroot=lvm2&r1=1.32&r2=1.33

--- LVM2/WHATS_NEW	2012/01/20 03:56:18	1.2226
+++ LVM2/WHATS_NEW	2012/01/20 10:55:28	1.2227
@@ -1,5 +1,6 @@
 Version 2.02.89 - 
 ==================================
+  Do not report linear segtype for non-striped targets.
   Keep info about creation host and time for each logical volume.
   Make error message hit when preallocated memlock memory exceeded clearer.
   Use R lv_attr to indicate read-only activation of non-read-only device in lvs.
--- LVM2/lib/metadata/lv.c	2012/01/19 15:34:33	1.32
+++ LVM2/lib/metadata/lv.c	2012/01/20 10:55:28	1.33
@@ -116,10 +116,6 @@
 
 char *lvseg_segtype_dup(struct dm_pool *mem, const struct lv_segment *seg)
 {
-	if (seg->area_count == 1) {
-		return (char *)"linear";
-	}
-
 	return dm_pool_strdup(mem, seg->segtype->ops->name(seg));
 }
 


             reply	other threads:[~2012-01-20 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 10:55 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-02-27 11:13 zkabelac
2011-09-23 15:17 jbrassow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120120105529.1867.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).