public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/metadata lv.c Date: Fri, 20 Jan 2012 10:56:00 -0000 [thread overview] Message-ID: <20120120105630.2045.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-01-20 10:56:30 Modified files: lib/metadata : lv.c Log message: Thin cleanup Reorder condition so the code is better readable (and shorter). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv.c.diff?cvsroot=lvm2&r1=1.33&r2=1.34 --- LVM2/lib/metadata/lv.c 2012/01/20 10:55:28 1.33 +++ LVM2/lib/metadata/lv.c 2012/01/20 10:56:30 1.34 @@ -182,11 +182,10 @@ { struct lv_segment *seg; - dm_list_iterate_items(seg, &lv->segments) { - if (!seg_is_mirrored(seg) || !seg->log_lv) - continue; - return dm_pool_strdup(mem, seg->log_lv->name); - } + dm_list_iterate_items(seg, &lv->segments) + if (seg_is_mirrored(seg) && seg->log_lv) + return dm_pool_strdup(mem, seg->log_lv->name); + return NULL; } @@ -194,11 +193,10 @@ { struct lv_segment *seg; - dm_list_iterate_items(seg, &lv->segments) { - if (!seg_is_thin_volume(seg) || !seg->pool_lv) - continue; - return dm_pool_strdup(mem, seg->pool_lv->name); - } + dm_list_iterate_items(seg, &lv->segments) + if (seg_is_thin_volume(seg) && seg->pool_lv) + return dm_pool_strdup(mem, seg->pool_lv->name); + return NULL; }
next reply other threads:[~2012-01-20 10:56 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-01-20 10:56 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-23 22:31 zkabelac 2011-09-14 10:03 zkabelac 2010-10-12 17:09 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120120105630.2045.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).