public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: snitzer@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/lv_manip.c Date: Fri, 20 Jan 2012 22:04:00 -0000 [thread overview] Message-ID: <20120120220416.28389.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: snitzer@sourceware.org 2012-01-20 22:04:16 Modified files: . : WHATS_NEW lib/metadata : lv_manip.c Log message: Prompt if request is made to remove a snapshot whose "Merge failed". Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2232&r2=1.2233 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv_manip.c.diff?cvsroot=lvm2&r1=1.344&r2=1.345 --- LVM2/WHATS_NEW 2012/01/20 22:03:48 1.2232 +++ LVM2/WHATS_NEW 2012/01/20 22:04:16 1.2233 @@ -1,5 +1,6 @@ Version 2.02.89 - ================================== + Prompt if request is made to remove a snapshot whose "Merge failed". Allow removal of an invalid snapshot that was to be merged on next activation. Don't allow a user to merge an invalid snapshot. Use m and M lv_attr to indicate that a snapshot merge failed in lvs. --- LVM2/lib/metadata/lv_manip.c 2012/01/20 22:03:48 1.344 +++ LVM2/lib/metadata/lv_manip.c 2012/01/20 22:04:16 1.345 @@ -3271,7 +3271,7 @@ if (lv_is_cow(lv)) { /* * A merging snapshot cannot be removed directly unless - * it has been invalidated. + * it has been invalidated or failed merge removal is requested. */ if (lv_is_merging_cow(lv) && !level) { if (lv_info(lv->vg->cmd, lv, 0, &info, 1, 0) && @@ -3283,6 +3283,13 @@ lv->name); return 0; } + else if ((snap_percent == PERCENT_MERGE_FAILED) && + (force == PROMPT) && + yes_no_prompt("Removing snapshot \"%s\" that failed to merge may leave origin \"%s\" inconsistent. " + "Proceed? [y/n]: ", lv->name, origin_from_cow(lv)->name) == 'n') { + log_error("Logical volume %s not removed.", lv->name); + return 0; + } } } }
next reply other threads:[~2012-01-20 22:04 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-01-20 22:04 snitzer [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-11 22:19 agk 2012-05-11 18:59 agk 2012-05-09 12:12 zkabelac 2012-03-05 14:13 zkabelac 2012-02-29 22:09 zkabelac 2012-02-22 17:14 jbrassow 2012-02-09 15:13 prajnoha 2012-02-08 13:02 zkabelac 2011-11-15 17:32 zkabelac 2011-11-15 17:28 zkabelac 2011-10-28 20:23 zkabelac 2011-10-28 20:17 zkabelac 2011-09-14 14:20 mbroz 2011-09-13 18:43 jbrassow 2011-06-29 17:05 agk 2011-04-07 21:49 jbrassow 2011-02-27 1:16 agk 2011-01-28 2:58 snitzer 2010-12-20 14:38 zkabelac 2010-12-01 12:56 zkabelac 2010-03-29 17:59 agk 2010-03-25 18:16 agk 2010-03-23 15:07 agk 2010-01-12 20:53 agk 2010-01-05 15:58 mbroz 2009-05-30 0:09 agk 2009-05-28 1:59 agk 2009-05-28 0:29 agk 2008-12-19 15:26 mbroz 2008-10-23 11:21 agk 2008-10-17 10:57 agk 2008-09-29 9:59 mbroz 2008-02-22 13:22 agk 2007-01-05 15:53 mbroz 2006-12-12 19:30 agk 2006-10-30 16:10 agk 2006-10-07 23:40 agk 2006-10-07 12:41 agk 2006-10-07 11:00 agk 2006-10-05 21:24 agk 2005-11-28 20:01 agk 2005-11-24 18:46 agk 2005-07-12 14:50 agk 2005-06-03 18:07 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120120220416.28389.qmail@sourceware.org \ --to=snitzer@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).