public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib activate/activate.c thin/thin.c
Date: Wed, 25 Jan 2012 08:51:00 -0000	[thread overview]
Message-ID: <20120125085129.23825.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2012-01-25 08:51:29

Modified files:
	lib/activate   : activate.c 
	lib/thin       : thin.c 

Log message:
	Comment cleanups
	
	Move comment where it applies and remove unused attribe when the var
	is actually used.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/activate.c.diff?cvsroot=lvm2&r1=1.234&r2=1.235
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/thin/thin.c.diff?cvsroot=lvm2&r1=1.42&r2=1.43

--- LVM2/lib/activate/activate.c	2012/01/25 08:48:43	1.234
+++ LVM2/lib/activate/activate.c	2012/01/25 08:51:29	1.235
@@ -1502,16 +1502,6 @@
 }
 ***********/
 
- /*
-  * _lv_resume
-  * @cmd
-  * @lvid_s
-  * @origin_only
-  * @exclusive:  This parameter only has an affect in cluster-context.
-  *		 It forces local target type to be used (instead of
-  *		 cluster-aware type).
-  * @error_if_not_active
-  */
 static int _lv_resume(struct cmd_context *cmd, const char *lvid_s,
 		      struct lv_activate_opts *laopts, int error_if_not_active)
 {
@@ -1574,6 +1564,10 @@
  * In a cluster, set exclusive to indicate that only one node is using the
  * device.  Any tables loaded may then use non-clustered targets.
  *
+ * @origin_only
+ * @exclusive   This parameter only has an affect in cluster-context.
+ *              It forces local target type to be used (instead of
+ *              cluster-aware type).
  * Returns success if the device is not active
  */
 int lv_resume_if_active(struct cmd_context *cmd, const char *lvid_s,
--- LVM2/lib/thin/thin.c	2012/01/24 00:55:04	1.42
+++ LVM2/lib/thin/thin.c	2012/01/25 08:51:29	1.43
@@ -212,11 +212,11 @@
 
 #ifdef DEVMAPPER_SUPPORT
 static int _thin_pool_add_target_line(struct dev_manager *dm,
-				      struct dm_pool *mem __attribute__((unused)),
-				      struct cmd_context *cmd __attribute__((unused)),
+				      struct dm_pool *mem,
+				      struct cmd_context *cmd,
 				      void **target_state __attribute__((unused)),
 				      struct lv_segment *seg,
-				      const struct lv_activate_opts *laopts __attribute__((unused)),
+				      const struct lv_activate_opts *laopts,
 				      struct dm_tree_node *node, uint64_t len,
 				      uint32_t *pvmove_mirror_count __attribute__((unused)))
 {


                 reply	other threads:[~2012-01-25  8:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120125085129.23825.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).