From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28866 invoked by alias); 25 Jan 2012 09:02:37 -0000 Received: (qmail 28848 invoked by uid 9737); 25 Jan 2012 09:02:36 -0000 Date: Wed, 25 Jan 2012 09:02:00 -0000 Message-ID: <20120125090236.28846.qmail@sourceware.org> From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/metadata lv_manip.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00069.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-01-25 09:02:35 Modified files: lib/metadata : lv_manip.c Log message: Thin check for lv_thin_pool_percent error status Check has been missing. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv_manip.c.diff?cvsroot=lvm2&r1=1.349&r2=1.350 --- LVM2/lib/metadata/lv_manip.c 2012/01/25 08:57:25 1.349 +++ LVM2/lib/metadata/lv_manip.c 2012/01/25 09:02:35 1.350 @@ -4340,9 +4340,13 @@ init_dmeventd_monitor(lp->activation_monitoring); if (seg_is_thin(lp)) { - /* For thin snapshot suspend active thin origin first */ + /* For snapshot, suspend active thin origin first */ if (org && lv_is_active(org)) { - lv_thin_pool_percent(first_seg(org)->pool_lv, 0, &percent); + /* Check if the pool is bellow threshold (Works only for active thin) */ + if (!lv_thin_pool_percent(first_seg(org)->pool_lv, 0, &percent)) { + stack; + goto revert_new_lv; + } percent /= PERCENT_1; if (percent >= (find_config_tree_int(cmd, "activation/thin_pool_autoextend_threshold", DEFAULT_THIN_POOL_AUTOEXTEND_THRESHOLD))) {