public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/activate/dev_manager.c Date: Wed, 01 Feb 2012 13:47:00 -0000 [thread overview] Message-ID: <20120201134728.22038.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-01 13:47:27 Modified files: . : WHATS_NEW lib/activate : dev_manager.c Log message: Disable partial activation for thin LVs and LVs with all missing segments Count number of error and existing areas and if there is no existing area for the LV avoid its activation. Always disable partial activatio for thin volumes. For mirrors currently put in hack to let it pass with a special name since current mirror code needs to activate such LV during some operations. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2252&r2=1.2253 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/dev_manager.c.diff?cvsroot=lvm2&r1=1.269&r2=1.270 --- LVM2/WHATS_NEW 2012/02/01 13:42:18 1.2252 +++ LVM2/WHATS_NEW 2012/02/01 13:47:27 1.2253 @@ -1,5 +1,6 @@ Version 2.02.90 - =================================== + Disable partial activation for thin LVs and LVs with all missing segments. Do not print warning for pv_min_size set in range between 512KB and 2MB. Clean up systemd unit ordering and requirements. Fix lcov reports when srcdir != builddir. --- LVM2/lib/activate/dev_manager.c 2012/01/28 20:12:29 1.269 +++ LVM2/lib/activate/dev_manager.c 2012/02/01 13:47:27 1.270 @@ -1373,6 +1373,8 @@ char *dlid; struct stat info; const char *name; + unsigned num_error_areas = 0; + unsigned num_existing_areas = 0; /* FIXME Avoid repeating identical stat in dm_tree_node_add_target_area */ for (s = start_area; s < areas; s++) { @@ -1388,10 +1390,12 @@ } if (!_add_error_area(dm, node, seg, s)) return_0; + num_error_areas++; } else if (seg_type(seg, s) == AREA_PV) { if (!dm_tree_node_add_target_area(node, dev_name(seg_dev(seg, s)), NULL, (seg_pv(seg, s)->pe_start + (extent_size * seg_pe(seg, s))))) return_0; + num_existing_areas++; } else if (seg_is_raid(seg)) { /* * RAID can handle unassigned areas. It simple puts @@ -1436,6 +1440,28 @@ } } + if (num_error_areas) { + /* Thins currently do not support partial activation */ + if (lv_is_thin_type(seg->lv)) { + log_error("Cannot activate %s%s: pool incomplete.", + seg->lv->vg->name, seg->lv->name); + return 0; + } + + /* + * Mirrors activate LVs replaced with error targets + * + * TODO: Can we eventually skip to activate such LVs ? + */ + if (!num_existing_areas && + !strstr(seg->lv->name, "_mimage_") && + !((name = strstr(seg->lv->name, "_mlog")) && !name[5])) { + log_error("Cannot activate %s/%s: all segments missing.", + seg->lv->vg->name, seg->lv->name); + return 0; + } + } + return 1; }
next reply other threads:[~2012-02-01 13:47 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-01 13:47 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-16 12:50 agk 2012-04-20 14:17 jbrassow 2012-03-05 14:15 zkabelac 2012-01-28 20:12 zkabelac 2012-01-23 20:56 jbrassow 2012-01-20 21:56 snitzer 2011-12-21 12:59 zkabelac 2011-11-18 19:42 zkabelac 2011-10-11 8:59 zkabelac 2011-10-11 8:57 zkabelac 2011-08-11 4:18 jbrassow 2011-07-06 0:29 agk 2011-07-05 23:10 agk 2011-01-05 14:03 zkabelac 2010-12-08 19:26 agk 2010-10-25 10:37 agk 2010-10-24 17:37 snitzer 2010-08-26 14:21 jbrassow 2010-08-17 1:51 agk 2010-08-03 13:13 zkabelac 2010-05-24 9:01 zkabelac 2010-05-21 14:48 zkabelac 2010-02-08 23:28 snitzer 2010-01-26 7:58 mbroz 2010-01-22 15:40 snitzer 2009-08-03 18:09 agk 2009-05-28 1:11 agk 2009-05-13 14:13 zkabelac 2008-12-19 15:23 mbroz 2008-06-05 12:45 agk 2007-05-14 11:27 mbroz 2007-03-08 19:58 agk 2006-11-20 16:45 agk 2006-07-10 19:17 agk 2005-10-18 12:39 agk 2005-08-04 1:27 agk 2005-08-04 1:15 agk 2004-05-12 20:43 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120201134728.22038.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).