public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW_DM libdm/libdm-common.c Date: Wed, 08 Feb 2012 11:07:00 -0000 [thread overview] Message-ID: <20120208110718.28491.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-08 11:07:17 Modified files: . : WHATS_NEW_DM libdm : libdm-common.c Log message: Fix fd resource leak in error path Use 'goto bad' to cleanup fd on error path. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.539&r2=1.540 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-common.c.diff?cvsroot=lvm2&r1=1.135&r2=1.136 --- LVM2/WHATS_NEW_DM 2012/02/08 11:05:04 1.539 +++ LVM2/WHATS_NEW_DM 2012/02/08 11:07:17 1.540 @@ -1,5 +1,6 @@ Version 1.02.70 - =================================== + Fix fd resource leak in error path for _udev_notify_sem_create(). Leave space for '\0' for readline() call in _sysfs_get_kernel_name(). Version 1.02.69 - 1st February 2012 --- LVM2/libdm/libdm-common.c 2012/02/08 11:05:05 1.135 +++ LVM2/libdm/libdm-common.c 2012/02/08 11:07:17 1.136 @@ -1738,7 +1738,7 @@ log_error("semid %d: sem_ctl GETVAL failed for " "cookie 0x%" PRIx32 ": %s", gen_semid, gen_cookie, strerror(errno)); - return 0; + goto bad; } log_debug("Udev cookie 0x%" PRIx32 " (semid %d) incremented to %d",
next reply other threads:[~2012-02-08 11:07 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-08 11:07 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-05 12:45 prajnoha 2012-02-28 8:36 prajnoha 2012-02-13 10:49 zkabelac 2011-03-30 12:14 zkabelac 2010-08-03 7:56 prajnoha 2010-05-27 15:02 prajnoha 2009-09-25 18:08 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120208110718.28491.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).