LVM2 ./WHATS_NEW lib/label/label.c

LVM2 ./WHATS_NEW lib/label/label.c

[zkabelac]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2012-02-08 11:12:18

Modified files:
	.              : WHATS_NEW 
	lib/label      : label.c 

Log message:
	Use dm_list_iterate_items_safe
	
	And avoid direct access to list member variables.
	Inline _free_li().

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2263&r2=1.2264
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/label/label.c.diff?cvsroot=lvm2&r1=1.54&r2=1.55

--- LVM2/WHATS_NEW	2012/02/08 11:05:04	1.2263
+++ LVM2/WHATS_NEW	2012/02/08 11:12:18	1.2264
@@ -1,5 +1,6 @@
 Version 2.02.91 -
 ===================================
+  Use list functions for label_exit().
   Ensure strncpy() function always ends with '\0'.
   Set status in _fsadm_cmd() for error path.
   Add missing deps for lvm2api for rebuild when lvm-internal is changed.
--- LVM2/lib/label/label.c	2011/06/01 15:30:36	1.54
+++ LVM2/lib/label/label.c	2012/02/08 11:12:18	1.55
@@ -56,11 +56,6 @@
 	return li;
 }
 
-static void _free_li(struct labeller_i *li)
-{
-	dm_free(li);
-}
-
 int label_init(void)
 {
 	dm_list_init(&_labellers);
@@ -69,14 +64,12 @@
 
 void label_exit(void)
 {
-	struct dm_list *c, *n;
-	struct labeller_i *li;
+	struct labeller_i *li, *tli;
 
-	for (c = _labellers.n; c && c != &_labellers; c = n) {
-		n = c->n;
-		li = dm_list_item(c, struct labeller_i);
+	dm_list_iterate_items_safe(li, tli, &_labellers) {
+		dm_list_del(&li->list);
 		li->l->ops->destroy(li->l);
-		_free_li(li);
+		dm_free(li);
 	}
 
 	dm_list_init(&_labellers);

LVM2 ./WHATS_NEW lib/label/label.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2011-06-01 15:30:36

Modified files:
	.              : WHATS_NEW 
	lib/label      : label.c 

Log message:
	Report sector containing label in verbose message.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2001&r2=1.2002
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/label/label.c.diff?cvsroot=lvm2&r1=1.53&r2=1.54

--- LVM2/WHATS_NEW	2011/06/01 12:24:15	1.2001
+++ LVM2/WHATS_NEW	2011/06/01 15:30:36	1.2002
@@ -1,5 +1,6 @@
 Version 2.02.86 -  
 =================================
+  Report sector containing label in verbose message.
   Clarify error message when unable to convert an LV into a snapshot of an LV.
   Add and use dev_open_readonly and variations.
   Do not log a superfluous stack message when the lv is properly processed.
--- LVM2/lib/label/label.c	2011/05/28 09:48:16	1.53
+++ LVM2/lib/label/label.c	2011/06/01 15:30:36	1.54
@@ -156,8 +156,10 @@
 		dm_list_iterate_items(li, &_labellers) {
 			if (li->l->ops->can_handle(li->l, (char *) lh,
 						   sector + scan_sector)) {
-				log_very_verbose("%s: %s label detected",
-						 dev_name(dev), li->name);
+				log_very_verbose("%s: %s label detected at "
+					         "sector %" PRIu64, 
+						 dev_name(dev), li->name,
+						 sector + scan_sector);
 				if (found) {
 					log_error("Ignoring additional label "
 						  "on %s at sector %" PRIu64,

LVM2 ./WHATS_NEW lib/label/label.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2006-11-14 15:03:07

Modified files:
	.              : WHATS_NEW 
	lib/label      : label.c 

Log message:
	Fix a label_verify error path.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.495&r2=1.496
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/label/label.c.diff?cvsroot=lvm2&r1=1.34&r2=1.35

--- LVM2/WHATS_NEW	2006/11/10 21:27:51	1.495
+++ LVM2/WHATS_NEW	2006/11/14 15:03:07	1.496
@@ -1,5 +1,6 @@
 Version 2.02.15 -
 ====================================
+  Fix a label_verify error path.
 
 Version 2.02.14 - 10th November 2006
 ====================================
--- LVM2/lib/label/label.c	2006/06/08 22:15:49	1.34
+++ LVM2/lib/label/label.c	2006/11/14 15:03:07	1.35
@@ -347,13 +347,11 @@
 	int r = 0;
 
 	if (!dev_open(dev)) {
-		stack;
-
 		if ((info = info_from_pvid(dev->pvid)))
 			lvmcache_update_vgname_and_id(info, ORPHAN, ORPHAN,
 						      0, NULL);
 
-		goto out;
+		return_0;
 	}
 
 	if (!(l = _find_labeller(dev, buf, &sector)))

LVM2 ./WHATS_NEW lib/label/label.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2006-06-08 22:15:49

Modified files:
	.              : WHATS_NEW 
	lib/label      : label.c 

Log message:
	Fix an extra dev_close in a label_read error path.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.396&r2=1.397
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/label/label.c.diff?cvsroot=lvm2&r1=1.33&r2=1.34

Full Patch:
--- LVM2/WHATS_NEW	2006/06/06 17:44:11	1.396
+++ LVM2/WHATS_NEW	2006/06/08 22:15:49	1.397
@@ -1,5 +1,6 @@
 Version 2.02.07 -
 =================================
+  Fix an extra dev_close in a label_read error path.
   Append patches to commit emails.
   Fix target_register_events args.
   Prevent snapshots of mirrors.
--- LVM2/lib/label/label.c	2006/05/09 21:23:50	1.33
+++ LVM2/lib/label/label.c	2006/06/08 22:15:49	1.34
@@ -271,7 +271,7 @@
 			lvmcache_update_vgname_and_id(info, ORPHAN, ORPHAN,
 						      0, NULL);
 
-		goto out;
+		return r;
 	}
 
 	if (!(l = _find_labeller(dev, buf, &sector)))

LVM2 ./WHATS_NEW lib/label/label.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2005-03-10 20:23:37

Modified files:
	.              : WHATS_NEW 
	lib/label      : label.c 

Log message:
	read/write may be macros

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.201&r2=1.202
http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/lib/label/label.c.diff?cvsroot=lvm2&r1=1.23&r2=1.24