public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/device dev-io.c Date: Wed, 08 Feb 2012 11:15:00 -0000 [thread overview] Message-ID: <20120208111538.31158.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-08 11:15:38 Modified files: lib/device : dev-io.c Log message: Move close few lines Since the function dev_close() has code path, which really could close file (for unlocked vg) and destroy dev handler, stay on safe side and move the close few lines later, even our current use case shouldn't trigger such scenario. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/device/dev-io.c.diff?cvsroot=lvm2&r1=1.79&r2=1.80 --- LVM2/lib/device/dev-io.c 2011/12/21 13:24:25 1.79 +++ LVM2/lib/device/dev-io.c 2012/02/08 11:15:38 1.80 @@ -1,6 +1,6 @@ /* * Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved. - * Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved. + * Copyright (C) 2004-2012 Red Hat, Inc. All rights reserved. * * This file is part of LVM2. * @@ -292,15 +292,15 @@ return 0; } - if (!dev_close(dev)) - stack; - *read_ahead = (uint32_t) read_ahead_long; dev->read_ahead = read_ahead_long; log_very_verbose("%s: read_ahead is %u sectors", dev_name(dev), *read_ahead); + if (!dev_close(dev)) + stack; + return 1; }
next reply other threads:[~2012-02-08 11:15 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-08 11:15 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-09-27 19:15 agk 2010-04-01 14:30 agk 2005-10-27 17:44 agk 2005-04-07 12:25 agk 2004-12-12 21:47 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120208111538.31158.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).