public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/format_text/archiver.c Date: Wed, 08 Feb 2012 12:50:00 -0000 [thread overview] Message-ID: <20120208125011.21758.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-08 12:50:11 Modified files: . : WHATS_NEW lib/format_text: archiver.c Log message: Use dm_snprintf and improve error handling Add standard error reporting with error logging. Use plain alloc instead of zalloc for string buffer. Use dm_snprintf with valid test for <0. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2268&r2=1.2269 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/archiver.c.diff?cvsroot=lvm2&r1=1.48&r2=1.49 --- LVM2/WHATS_NEW 2012/02/08 12:48:14 1.2268 +++ LVM2/WHATS_NEW 2012/02/08 12:50:10 1.2269 @@ -1,5 +1,6 @@ Version 2.02.91 - =================================== + Fix error path handling in _build_desc() Add range test for device number in _scan_proc_dev(). Use signed long for sysconf() call in cmirrord. Do not write in front of log buffer in print_log(). --- LVM2/lib/format_text/archiver.c 2012/01/20 11:01:13 1.48 +++ LVM2/lib/format_text/archiver.c 2012/02/08 12:50:10 1.49 @@ -83,13 +83,16 @@ size_t len = strlen(line) + 32; char *buffer; - if (!(buffer = dm_pool_zalloc(mem, strlen(line) + 32))) - return_NULL; + if (!(buffer = dm_pool_alloc(mem, len))) { + log_error("Failed to allocate desc."); + return NULL; + } - if (snprintf(buffer, len, - "Created %s executing '%s'", - before ? "*before*" : "*after*", line) < 0) - return_NULL; + if (dm_snprintf(buffer, len, "Created %s executing '%s'", + before ? "*before*" : "*after*", line) < 0) { + log_error("Failed to build desc."); + return NULL; + } return buffer; }
next reply other threads:[~2012-02-08 12:50 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-08 12:50 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-12-22 13:45 zkabelac 2009-03-23 22:57 taka 2009-03-23 21:56 taka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120208125011.21758.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).