public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/cache/lvmcache.c lib/misc ... Date: Wed, 08 Feb 2012 12:57:00 -0000 [thread overview] Message-ID: <20120208125716.27071.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-08 12:57:15 Modified files: . : WHATS_NEW lib/cache : lvmcache.c lib/misc : lvm-string.c Log message: Some fixmes 'len' calculation is unused ? Unreachable code could be removed or moved upward ? Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2270&r2=1.2271 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.121&r2=1.122 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/misc/lvm-string.c.diff?cvsroot=lvm2&r1=1.32&r2=1.33 --- LVM2/WHATS_NEW 2012/02/08 12:52:58 1.2270 +++ LVM2/WHATS_NEW 2012/02/08 12:57:15 1.2271 @@ -1,7 +1,7 @@ Version 2.02.91 - =================================== - Switch int to void return for str_list_del() - Fix error path handling in _build_desc() + Switch int to void return for str_list_del(). + Fix error path handling in _build_desc(). Add range test for device number in _scan_proc_dev(). Use signed long for sysconf() call in cmirrord. Do not write in front of log buffer in print_log(). --- LVM2/lib/cache/lvmcache.c 2011/12/18 21:56:03 1.121 +++ LVM2/lib/cache/lvmcache.c 2012/02/08 12:57:15 1.122 @@ -987,6 +987,7 @@ if (vginfo && *vginfo->vgid) dm_hash_remove(_vgid_hash, vginfo->vgid); if (!vgid) { + /* FIXME: unreachable code path */ log_debug("lvmcache: %s: clearing VGID", info ? dev_name(info->dev) : vginfo->vgname); return 1; } --- LVM2/lib/misc/lvm-string.c 2011/11/03 14:38:36 1.32 +++ LVM2/lib/misc/lvm-string.c 2012/02/08 12:57:15 1.33 @@ -49,12 +49,13 @@ int validate_tag(const char *n) { register char c; - register int len = 0; + /* int len = 0; */ if (!n || !*n) return 0; - while ((len++, c = *n++)) + /* FIXME: Is unlimited tag size support needed ? */ + while ((/* len++, */ c = *n++)) if (!isalnum(c) && c != '.' && c != '_' && c != '-' && c != '+' && c != '/' && c != '=' && c != '!' && c != ':' && c != '&' && c != '#') return 0;
reply other threads:[~2012-02-08 12:57 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120208125716.27071.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).