public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW_DM libdm/ioctl/libdm-iface.c Date: Wed, 08 Feb 2012 12:59:00 -0000 [thread overview] Message-ID: <20120208125920.28523.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-08 12:59:20 Modified files: . : WHATS_NEW_DM libdm/ioctl : libdm-iface.c Log message: Use dm_asprintf to simplify code Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.541&r2=1.542 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.133&r2=1.134 --- LVM2/WHATS_NEW_DM 2012/02/08 11:25:09 1.541 +++ LVM2/WHATS_NEW_DM 2012/02/08 12:59:19 1.542 @@ -1,5 +1,6 @@ Version 1.02.70 - =================================== + Simplify dm_task_set_geometry() and use dm_asprintf(). Set all parameters to 0 for dm_get_next_target() for NULL return. Fix fd resource leak in error path for _udev_notify_sem_create(). Leave space for '\0' for readline() call in _sysfs_get_kernel_name(). --- LVM2/libdm/ioctl/libdm-iface.c 2012/02/08 11:25:10 1.133 +++ LVM2/libdm/ioctl/libdm-iface.c 2012/02/08 12:59:20 1.134 @@ -769,16 +769,11 @@ return 1; } -int dm_task_set_geometry(struct dm_task *dmt, const char *cylinders, const char *heads, const char *sectors, const char *start) +int dm_task_set_geometry(struct dm_task *dmt, const char *cylinders, const char *heads, + const char *sectors, const char *start) { - size_t len = strlen(cylinders) + 1 + strlen(heads) + 1 + strlen(sectors) + 1 + strlen(start) + 1; - - if (!(dmt->geometry = dm_malloc(len))) { - log_error("dm_task_set_geometry: dm_malloc failed"); - return 0; - } - - if (sprintf(dmt->geometry, "%s %s %s %s", cylinders, heads, sectors, start) < 0) { + if (dm_asprintf(&(dmt->geometry), "%s %s %s %s", + cylinders, heads, sectors, start) < 0) { log_error("dm_task_set_geometry: sprintf failed"); return 0; }
next reply other threads:[~2012-02-08 12:59 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-08 12:59 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-01 10:07 zkabelac 2012-02-15 12:17 prajnoha 2012-02-08 11:25 zkabelac 2011-11-08 17:32 snitzer 2011-10-20 10:38 zkabelac 2011-09-13 15:13 prajnoha 2011-08-11 20:49 zkabelac 2011-07-24 23:59 agk 2011-07-02 1:17 agk 2011-06-09 15:07 mbroz 2011-03-25 23:50 agk 2011-03-08 22:43 zkabelac 2011-03-01 23:27 agk 2011-02-21 16:26 snitzer 2010-08-18 13:11 prajnoha 2010-05-13 13:31 mbroz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120208125920.28523.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).