public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW_DM libdm/libdm-string.c
Date: Fri, 10 Feb 2012 13:56:00 -0000	[thread overview]
Message-ID: <20120210135621.27817.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2012-02-10 13:56:20

Modified files:
	.              : WHATS_NEW_DM 
	libdm          : libdm-string.c 

Log message:
	Return error for failing allocation
	
	Fix case, where final strdup would have failed and it would miss to return
	failure for this case and return success and NULL pointer.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.544&r2=1.545
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-string.c.diff?cvsroot=lvm2&r1=1.17&r2=1.18

--- LVM2/WHATS_NEW_DM	2012/02/10 13:52:05	1.544
+++ LVM2/WHATS_NEW_DM	2012/02/10 13:56:19	1.545
@@ -1,5 +1,6 @@
 Version 1.02.70 - 
 ===================================
+  Return error for failing allocation in dm_asprintf().
   Add missing test for failing allocation in dm_realloc() code.
   Add test for memory allocation failures in regex matcher code.
   Simplify dm_task_set_geometry() and use dm_asprintf().
--- LVM2/libdm/libdm-string.c	2011/09/14 16:07:07	1.17
+++ LVM2/libdm/libdm-string.c	2012/02/10 13:56:20	1.18
@@ -156,7 +156,9 @@
 		}
 	}
 
-	*result = dm_strdup(buf);
+	if (!(*result = dm_strdup(buf)))
+		n = -2; /* return -1 */
+
 	dm_free(buf);
 	return n + 1;
 }


             reply	other threads:[~2012-02-10 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 13:56 zkabelac [this message]
2012-02-23 18:05 zkabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120210135621.27817.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).