public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW_DM libdm/libdm-deptree.c Date: Fri, 10 Feb 2012 14:42:00 -0000 [thread overview] Message-ID: <20120210144230.16600.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-10 14:42:29 Modified files: . : WHATS_NEW_DM libdm : libdm-deptree.c Log message: Add validation of name and uuid Do not accept NULL pointers. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.546&r2=1.547 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.154&r2=1.155 --- LVM2/WHATS_NEW_DM 2012/02/10 14:00:07 1.546 +++ LVM2/WHATS_NEW_DM 2012/02/10 14:42:28 1.547 @@ -1,5 +1,6 @@ Version 1.02.70 - =================================== + Validate name and uuid params of dm_tree_add_new_dev_with_udev_flags(). Do not crash for dm_report_init() sort_key == NULL and behave like "". Return error for failing allocation in dm_asprintf(). Add missing test for failing allocation in dm_realloc() code. --- LVM2/libdm/libdm-deptree.c 2012/02/08 11:36:18 1.154 +++ LVM2/libdm/libdm-deptree.c 2012/02/10 14:42:28 1.155 @@ -1086,6 +1086,11 @@ const char *name2; const char *uuid2; + if (!name || !uuid) { + log_error("Cannot add device without name and uuid."); + return NULL; + } + /* Do we need to add node to tree? */ if (!(dnode = dm_tree_find_node_by_uuid(dtree, uuid))) { if (!(name2 = dm_pool_strdup(dtree->mem, name))) {
next reply other threads:[~2012-02-10 14:42 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-10 14:42 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-15 21:27 agk 2012-02-10 14:48 zkabelac 2012-01-25 21:50 zkabelac 2011-10-17 13:15 mbroz 2011-10-14 13:34 zkabelac 2011-10-03 18:28 zkabelac 2011-09-07 8:37 zkabelac 2011-02-18 16:13 zkabelac 2009-07-03 12:46 agk 2008-12-11 16:25 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120210144230.16600.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).