public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW_DM daemons/dmeventd/libdevmap ... Date: Fri, 10 Feb 2012 15:17:00 -0000 [thread overview] Message-ID: <20120210151752.8608.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-10 15:17:52 Modified files: . : WHATS_NEW_DM daemons/dmeventd: libdevmapper-event.c Log message: Fix message check Check pointer from strchr for NULL instead of crash later. Badly formated message would have crash dmeventd otherwise. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.548&r2=1.549 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/libdevmapper-event.c.diff?cvsroot=lvm2&r1=1.42&r2=1.43 --- LVM2/WHATS_NEW_DM 2012/02/10 14:48:28 1.548 +++ LVM2/WHATS_NEW_DM 2012/02/10 15:17:52 1.549 @@ -1,5 +1,6 @@ Version 1.02.70 - =================================== + Fix dm_event_get_version() check. Add pointer test for dependency check in _add_dev(). Validate name and uuid params of dm_tree_add_new_dev_with_udev_flags(). Do not crash for dm_report_init() sort_key == NULL and behave like "". --- LVM2/daemons/dmeventd/libdevmapper-event.c 2011/07/08 12:35:48 1.42 +++ LVM2/daemons/dmeventd/libdevmapper-event.c 2012/02/10 15:17:52 1.43 @@ -811,11 +811,11 @@ p = msg.data; *version = 0; - p = strchr(p, ' ') + 1; /* Message ID */ + p = strchr(p, ' '); /* Message ID */ if (!p) return 0; - p = strchr(p, ' ') + 1; /* HELLO */ + p = strchr(p + 1, ' '); /* HELLO */ if (!p) return 0; - p = strchr(p, ' '); /* HELLO, once more */ + p = strchr(p + 1, ' '); /* HELLO, once more */ if (p) *version = atoi(p); return 1;
next reply other threads:[~2012-02-10 15:17 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-10 15:17 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-20 17:38 zkabelac 2012-03-12 14:46 zkabelac 2012-02-15 13:56 zkabelac 2012-02-13 11:24 zkabelac 2009-06-15 12:29 mbroz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120210151752.8608.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).