public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW_DM tools/dmsetup.c Date: Mon, 13 Feb 2012 12:06:00 -0000 [thread overview] Message-ID: <20120213120641.6073.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-13 12:06:40 Modified files: . : WHATS_NEW_DM tools : dmsetup.c Log message: Ensure allocated device does not leak on error path For unimplementd canonicalize_file_name set to NULL Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.555&r2=1.556 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/dmsetup.c.diff?cvsroot=lvm2&r1=1.175&r2=1.176 --- LVM2/WHATS_NEW_DM 2012/02/13 11:24:09 1.555 +++ LVM2/WHATS_NEW_DM 2012/02/13 12:06:39 1.556 @@ -1,5 +1,6 @@ Version 1.02.71 - ==================================== + Fix memory leak in fail path of parse_loop_device_name() in dmsetup. Check for missing reply_uuid in dm_event_get_registered_device(). Check for allocation failure in dmeventd restart(). Add few missing allocation failures tests in dmsetup. --- LVM2/tools/dmsetup.c 2012/02/13 11:13:44 1.175 +++ LVM2/tools/dmsetup.c 2012/02/13 12:06:40 1.176 @@ -3043,6 +3043,8 @@ _path = canonicalize_file_name(path); #else /* FIXME Provide alternative */ + log_error(INTERNAL_ERROR "Unimplemented _get_abspath."); + _path = NULL; #endif return _path; } @@ -3050,7 +3052,7 @@ static char *parse_loop_device_name(const char *dev, const char *dev_dir) { char *buf; - char *device; + char *device = NULL; if (!(buf = dm_malloc(PATH_MAX))) return NULL; @@ -3083,7 +3085,9 @@ return buf; error: + dm_free(device); dm_free(buf); + return NULL; }
next reply other threads:[~2012-02-13 12:06 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-13 12:06 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-24 8:24 prajnoha 2012-04-24 8:00 prajnoha 2012-03-01 21:56 zkabelac 2012-02-15 12:08 prajnoha 2012-02-15 12:06 prajnoha 2012-02-15 12:03 prajnoha 2011-08-11 17:06 mbroz 2011-07-08 17:08 agk 2011-06-17 14:55 prajnoha 2011-03-29 21:49 zkabelac 2011-03-02 2:44 agk 2010-08-03 13:04 zkabelac 2010-08-03 12:56 zkabelac 2010-07-08 14:29 zkabelac 2009-06-03 20:44 agk 2009-06-03 18:35 agk 2009-04-24 11:30 prajnoha
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120213120641.6073.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).