public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: prajnoha@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools dmsetup.c
Date: Wed, 15 Feb 2012 14:21:00 -0000 [thread overview]
Message-ID: <20120215142100.27303.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: prajnoha@sourceware.org 2012-02-15 14:21:00
Modified files:
tools : dmsetup.c
Log message:
Fix segfault in dmsetup when using table specification with --table.
Segfault introduced with the patch that added dm_free(_table) at the
end of dmsetup (in this release).
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/dmsetup.c.diff?cvsroot=lvm2&r1=1.179&r2=1.180
--- LVM2/tools/dmsetup.c 2012/02/15 12:08:57 1.179
+++ LVM2/tools/dmsetup.c 2012/02/15 14:20:59 1.180
@@ -3654,7 +3654,11 @@
_switches[SHOWKEYS_ARG]++;
if (ind == TABLE_ARG) {
_switches[TABLE_ARG]++;
- _table = optarg;
+ if (!(_table = dm_malloc(strlen(optarg + 1)))) {
+ log_error("Could not allocate memory for table string.");
+ return 0;
+ }
+ strcpy(_table, optarg);
}
if (ind == TREE_ARG)
_switches[TREE_ARG]++;
next reply other threads:[~2012-02-15 14:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 14:21 prajnoha [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-01 21:50 zkabelac
2012-02-15 14:27 zkabelac
2012-01-20 10:58 zkabelac
2011-12-01 14:57 agk
2011-03-29 21:56 zkabelac
2010-12-20 14:36 zkabelac
2010-11-30 22:53 zkabelac
2010-10-25 13:36 zkabelac
2010-07-08 13:31 zkabelac
2010-07-05 22:56 agk
2009-12-11 13:04 zkabelac
2009-08-06 15:56 prajnoha
2009-08-06 15:05 prajnoha
2008-10-31 18:53 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215142100.27303.qmail@sourceware.org \
--to=prajnoha@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).