From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-5096-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 16881 invoked by alias); 22 Feb 2012 15:20:52 -0000
Received: (qmail 16859 invoked by uid 9478); 22 Feb 2012 15:20:51 -0000
Date: Wed, 22 Feb 2012 15:20:00 -0000
Message-ID: <20120222152051.16857.qmail@sourceware.org>
From: jbrassow@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools lvconvert.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00130.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	jbrassow@sourceware.org	2012-02-22 15:20:51

Modified files:
	tools          : lvconvert.c 

Log message:
	Fix a bad return code in 'lvconvert_raid'
	
	Functions at this level do return 0 or 1, not ECMD_* values.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.182&r2=1.183

--- LVM2/tools/lvconvert.c	2012/02/13 18:38:36	1.182
+++ LVM2/tools/lvconvert.c	2012/02/22 15:20:50	1.183
@@ -1528,10 +1528,9 @@
 		_lvconvert_raid_repair_ask(cmd, &replace);
 
 		if (replace) {
-			if (!(failed_pvs = _failed_pv_list(lv->vg))) {
-				stack;
-				return ECMD_FAILED;
-			}
+			if (!(failed_pvs = _failed_pv_list(lv->vg)))
+				return_0;
+
 			return lv_raid_replace(lv, failed_pvs, lp->pvh);
 		}