public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvcreate.c Date: Mon, 27 Feb 2012 10:00:00 -0000 [thread overview] Message-ID: <20120227100028.11061.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-27 10:00:24 Modified files: . : WHATS_NEW tools : lvcreate.c Log message: Always check result of _set_vg_name() Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2311&r2=1.2312 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.255&r2=1.256 --- LVM2/WHATS_NEW 2012/02/27 09:58:18 1.2311 +++ LVM2/WHATS_NEW 2012/02/27 10:00:23 1.2312 @@ -1,6 +1,7 @@ Version 2.02.94 - -==================================== - Drop unused call to uname() during clvmd initia.lization. +==================================== + Always check result of _set_vg_name() in lvcreate. + Drop unused call to uname() during clvmd initialization. Test allocation result in sysfs filter creation. Limit sscanf parameters with buffer size in clvmd get_initial_state(). Use const lv pointer for lv_is_active...() functions. --- LVM2/tools/lvcreate.c 2012/02/23 17:36:36 1.255 +++ LVM2/tools/lvcreate.c 2012/02/27 10:00:23 1.256 @@ -93,8 +93,9 @@ lp->origin = ptr + 1; } - if (!lp->vg_name) - _set_vg_name(lp, extract_vgname(cmd, NULL)); + if (!lp->vg_name && + !_set_vg_name(lp, extract_vgname(cmd, NULL))) + return_0; if (!lp->vg_name) { log_error("The origin name should include the " @@ -115,8 +116,9 @@ if (!_set_vg_name(lp, extract_vgname(cmd, lp->pool))) return_0; - if (!lp->vg_name) - _set_vg_name(lp, extract_vgname(cmd, NULL)); + if (!lp->vg_name && + !_set_vg_name(lp, extract_vgname(cmd, NULL))) + return_0; if (!lp->vg_name) { log_error("The pool name should include the "
next reply other threads:[~2012-02-27 10:00 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-27 10:00 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-11 12:33 zkabelac 2012-03-02 17:25 zkabelac 2012-03-01 21:21 zkabelac 2011-11-07 11:01 zkabelac 2011-09-22 15:36 jbrassow 2008-09-24 16:32 mbroz 2008-06-05 13:38 agk 2008-01-17 15:53 agk 2008-01-16 15:25 agk 2007-11-12 13:34 agk 2007-09-24 13:25 wysochanski 2007-09-17 17:18 agk 2007-07-17 16:13 mbroz 2006-10-26 18:22 agk 2006-05-24 13:58 agk 2005-06-22 14:56 agk 2004-10-15 15:53 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120227100028.11061.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).