public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2/daemons/clvmd clvmd-command.c
@ 2012-02-27 10:02 zkabelac
  0 siblings, 0 replies; 4+ messages in thread
From: zkabelac @ 2012-02-27 10:02 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2012-02-27 10:02:17

Modified files:
	daemons/clvmd  : clvmd-command.c 

Log message:
	Explicitely ignore result from sync_unlock()
	
	Make it obvious to analyzer - we can't do anything better here anyway.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-command.c.diff?cvsroot=lvm2&r1=1.65&r2=1.66

--- LVM2/daemons/clvmd/clvmd-command.c	2012/02/23 22:23:12	1.65
+++ LVM2/daemons/clvmd/clvmd-command.c	2012/02/27 10:02:17	1.66
@@ -355,7 +355,7 @@
 		lkid = (int)(long)dm_hash_get_data(lock_hash, v);
 		lockname = dm_hash_get_key(lock_hash, v);
 		DEBUGLOG("cleanup: Unlocking lock %s %x\n", lockname, lkid);
-		sync_unlock(lockname, lkid);
+		(void) sync_unlock(lockname, lkid);
 	}
 
 	dm_hash_destroy(lock_hash);


^ permalink raw reply	[flat|nested] 4+ messages in thread
* LVM2/daemons/clvmd clvmd-command.c
@ 2010-10-20 14:51 mornfall
  0 siblings, 0 replies; 4+ messages in thread
From: mornfall @ 2010-10-20 14:51 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mornfall@sourceware.org	2010-10-20 14:51:18

Modified files:
	daemons/clvmd  : clvmd-command.c 

Log message:
	Revert some debug statements that slipped in with last checkin.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-command.c.diff?cvsroot=lvm2&r1=1.40&r2=1.41

--- LVM2/daemons/clvmd/clvmd-command.c	2010/10/20 14:46:45	1.40
+++ LVM2/daemons/clvmd/clvmd-command.c	2010/10/20 14:51:18	1.41
@@ -210,12 +210,9 @@
 
     if (lock_mode == LCK_UNLOCK) {
 
-        DEBUGLOG("PRE: UNLOCK\n");
 	lkid = (int)(long)dm_hash_lookup(lock_hash, lockname);
-	if (lkid == 0) {
-            DEBUGLOG("lock not found in table\n");
+	if (lkid == 0)
 	    return EINVAL;
-	}
 
 	status = sync_unlock(lockname, lkid);
 	if (status)
@@ -224,7 +221,6 @@
 	    dm_hash_remove(lock_hash, lockname);
     }
     else {
-        DEBUGLOG("PRE: LOCK\n");
 	/* Read locks need to be PR; other modes get passed through */
 	if (lock_mode == LCK_READ)
 	    lock_mode = LCK_PREAD;


^ permalink raw reply	[flat|nested] 4+ messages in thread
* LVM2/daemons/clvmd clvmd-command.c
@ 2010-04-30 14:51 agk
  0 siblings, 0 replies; 4+ messages in thread
From: agk @ 2010-04-30 14:51 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2010-04-30 14:51:58

Modified files:
	daemons/clvmd  : clvmd-command.c 

Log message:
	typo

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-command.c.diff?cvsroot=lvm2&r1=1.33&r2=1.34

--- LVM2/daemons/clvmd/clvmd-command.c	2010/04/30 14:49:44	1.33
+++ LVM2/daemons/clvmd/clvmd-command.c	2010/04/30 14:51:58	1.34
@@ -371,7 +371,7 @@
 	/*
 	 * Build the command-line
 	 */
-	/* FIXME missing strup error checks */
+	/* FIXME missing strdup error checks */
 	argv[0] = strdup("clvmd");
 
 	/* Propogate debug options */


^ permalink raw reply	[flat|nested] 4+ messages in thread
* LVM2/daemons/clvmd clvmd-command.c
@ 2004-09-23 12:29 pcaulfield
  0 siblings, 0 replies; 4+ messages in thread
From: pcaulfield @ 2004-09-23 12:29 UTC (permalink / raw)
  To: lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	pcaulfield@sourceware.org	2004-09-23 12:29:37

Modified files:
	daemons/clvmd  : clvmd-command.c 

Log message:
	Don't use hold_lock for VG locks as that doesn't stop processes contending
	on the same node, only across the cluster.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-command.c.diff?cvsroot=lvm2&r1=1.1&r2=1.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-27 10:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-27 10:02 LVM2/daemons/clvmd clvmd-command.c zkabelac
  -- strict thread matches above, loose matches on Subject: below --
2010-10-20 14:51 mornfall
2010-04-30 14:51 agk
2004-09-23 12:29 pcaulfield

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).