From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-5163-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 19381 invoked by alias); 27 Feb 2012 10:19:01 -0000
Received: (qmail 19360 invoked by uid 9737); 27 Feb 2012 10:19:00 -0000
Date: Mon, 27 Feb 2012 10:19:00 -0000
Message-ID: <20120227101900.19358.qmail@sourceware.org>
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/daemons/lvmetad lvmetad-core.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00197.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2012-02-27 10:19:00

Modified files:
	daemons/lvmetad: lvmetad-core.c 

Log message:
	Add assert for oldname
	
	Code cannot proceed if oldname would be NULL.
	Since lvmetad currently doesn't use logging mechanism of lvm to report
	internal errors - stay with current code style of lvmetad which uses
	plain asserts for cases like this.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/lvmetad/lvmetad-core.c.diff?cvsroot=lvm2&r1=1.43&r2=1.44

--- LVM2/daemons/lvmetad/lvmetad-core.c	2012/02/27 10:10:43	1.43
+++ LVM2/daemons/lvmetad/lvmetad-core.c	2012/02/27 10:19:00	1.44
@@ -595,6 +595,7 @@
 
 	if (!old)
 		return 0;
+	assert(oldname);
 
 	if (update_pvids)
 		update_pvid_to_vgid(s, old, "#orphan", 0);