public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/cache lvmetad.c Date: Mon, 27 Feb 2012 11:32:00 -0000 [thread overview] Message-ID: <20120227113248.4694.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-27 11:32:48 Modified files: lib/cache : lvmetad.c Log message: Check id_write_format result Currently we never fail with 64byte uuid buffer, but just stay consitent with rest of the code and check for result. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmetad.c.diff?cvsroot=lvm2&r1=1.6&r2=1.7 --- LVM2/lib/cache/lvmetad.c 2012/02/26 13:42:50 1.6 +++ LVM2/lib/cache/lvmetad.c 2012/02/27 11:32:48 1.7 @@ -153,7 +153,8 @@ return NULL; if (vgid) { - id_write_format((const struct id*)vgid, uuid, 64); + if (!id_write_format((const struct id*)vgid, uuid, sizeof(uuid))) + return_0; reply = daemon_send_simple(_lvmetad, "vg_lookup", "uuid = %s", uuid, NULL); } else { if (!vgname) @@ -293,7 +294,9 @@ if (!_using_lvmetad) return 1; /* just fake it */ - id_write_format(&vg->id, uuid, 64); + if (!id_write_format(&vg->id, uuid, sizeof(uuid))) + return_0; + reply = daemon_send_simple(_lvmetad, "vg_remove", "uuid = %s", uuid, NULL); return _lvmetad_handle_reply(reply, "remove VG", vg->name); @@ -309,7 +312,8 @@ if (!_using_lvmetad) return_0; - id_write_format(&pvid, uuid, 64); + if (!id_write_format(&pvid, uuid, sizeof(uuid))) + return_0; reply = daemon_send_simple(_lvmetad, "pv_lookup", "uuid = %s", uuid, NULL); @@ -482,7 +486,8 @@ if (!_using_lvmetad) return 1; - id_write_format(&pvid, uuid, 64); + if (!id_write_format(&pvid, uuid, sizeof(uuid))) + return_0; /* FIXME A more direct route would be much preferable. */ if ((info = lvmcache_info_from_pvid((const char *)&pvid, 0)))
next reply other threads:[~2012-02-27 11:32 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-27 11:32 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-14 17:15 zkabelac 2012-03-02 22:44 agk 2012-03-02 21:24 agk 2012-03-01 20:04 mornfall 2012-02-28 18:23 agk 2012-02-28 11:09 zkabelac 2012-02-26 13:42 mornfall 2012-02-26 8:49 mornfall 2012-02-23 19:03 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120227113248.4694.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).