public inbox for
help / color / mirror / Atom feed
Subject: LVM2/daemons/dmeventd dmeventd.h libdevmapper- ...
Date: Mon, 27 Feb 2012 11:46:00 -0000	[thread overview]
Message-ID: <> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	2012-02-27 11:46:26

Modified files:
	daemons/dmeventd: dmeventd.h libdevmapper-event.h 

Log message:
	Add FIXME for misuse in case of dm_event_mask enum.
	Using enum for bitmask is not proper solution here.


--- LVM2/daemons/dmeventd/dmeventd.h	2011/04/04 16:11:09	1.9
+++ LVM2/daemons/dmeventd/dmeventd.h	2012/02/27 11:46:25	1.10
@@ -63,6 +63,7 @@
 #define EXIT_CHDIR_FAILURE       7
 /* Implemented in libdevmapper-event.c, but not part of public API. */
+// FIXME  misuse of bitmask as enum
 int daemon_talk(struct dm_event_fifos *fifos,
 		struct dm_event_daemon_message *msg, int cmd,
 		const char *dso_name, const char *dev_name,
--- LVM2/daemons/dmeventd/libdevmapper-event.h	2011/04/04 16:11:09	1.16
+++ LVM2/daemons/dmeventd/libdevmapper-event.h	2012/02/27 11:46:25	1.17
@@ -82,6 +82,7 @@
  * Specify mask for events to monitor.
+// FIXME  misuse of bitmask as enum
 void dm_event_handler_set_event_mask(struct dm_event_handler *dmevh,
 				     enum dm_event_mask evmask);
@@ -91,6 +92,7 @@
 int dm_event_handler_get_major(const struct dm_event_handler *dmevh);
 int dm_event_handler_get_minor(const struct dm_event_handler *dmevh);
 int dm_event_handler_get_timeout(const struct dm_event_handler *dmevh);
+// FIXME  misuse of bitmask as enum
 enum dm_event_mask dm_event_handler_get_event_mask(const struct dm_event_handler *dmevh);
 /* FIXME Review interface (what about this next thing?) */
@@ -104,6 +106,7 @@
 /* Prototypes for DSO interface, see dmeventd.c, struct dso_data for
    detailed descriptions. */
+// FIXME  misuse of bitmask as enum
 void process_event(struct dm_task *dmt, enum dm_event_mask evmask, void **user);
 int register_device(const char *device_name, const char *uuid, int major, int minor, void **user);
 int unregister_device(const char *device_name, const char *uuid, int major,

                 reply	other threads:[~2012-02-27 11:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).