public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW daemons/clvmd/clvmd.c Date: Tue, 28 Feb 2012 09:53:00 -0000 [thread overview] Message-ID: <20120228095357.10415.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-02-28 09:53:55 Modified files: . : WHATS_NEW daemons/clvmd : clvmd.c Log message: Do not send uninitilised bytes Use struct initalizers to fill struct members and at the same time have all unspecified members set to 0. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2318&r2=1.2319 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd.c.diff?cvsroot=lvm2&r1=1.124&r2=1.125 --- LVM2/WHATS_NEW 2012/02/27 11:45:05 1.2318 +++ LVM2/WHATS_NEW 2012/02/28 09:53:55 1.2319 @@ -1,5 +1,6 @@ Version 2.02.94 - ==================================== + Do not send uninitilised bytes in cluster error reply messages. Use unsigned type for bitmask instead of enum type for lvm properties. Add missing cleanup of excl_uuid hash on some exit paths of clvmd. Check for existance of vg_name in _format1/_pool_vg_read(). --- LVM2/daemons/clvmd/clvmd.c 2012/02/27 11:28:47 1.124 +++ LVM2/daemons/clvmd/clvmd.c 2012/02/28 09:53:55 1.125 @@ -1185,11 +1185,10 @@ /* If we are already busy then return an error */ if (thisfd->bits.localsock.in_progress) { - struct clvm_header reply; - reply.cmd = CLVMD_CMD_REPLY; - reply.status = EBUSY; - reply.arglen = 0; - reply.flags = 0; + struct clvm_header reply = { + .cmd = CLVMD_CMD_REPLY, + .status = EBUSY + }; send_message(&reply, sizeof(reply), our_csid, thisfd->fd, "Error sending EBUSY reply to local user"); @@ -1206,11 +1205,10 @@ /* We need at least sizeof(struct clvm_header) bytes in buffer */ if (len < sizeof(struct clvm_header) || argslen < 0) { - struct clvm_header reply; - reply.cmd = CLVMD_CMD_REPLY; - reply.status = EINVAL; - reply.arglen = 0; - reply.flags = 0; + struct clvm_header reply = { + .cmd = CLVMD_CMD_REPLY, + .status = EINVAL + }; send_message(&reply, sizeof(reply), our_csid, thisfd->fd, "Error sending EINVAL reply to local user"); @@ -1224,11 +1222,10 @@ thisfd->bits.localsock.cmd = malloc(len + missing_len); if (!thisfd->bits.localsock.cmd) { - struct clvm_header reply; - reply.cmd = CLVMD_CMD_REPLY; - reply.status = ENOMEM; - reply.arglen = 0; - reply.flags = 0; + struct clvm_header reply = { + .cmd = CLVMD_CMD_REPLY, + .status = ENOMEM + }; send_message(&reply, sizeof(reply), our_csid, thisfd->fd, "Error sending ENOMEM reply to local user"); @@ -1283,13 +1280,12 @@ /* Check the node name for validity */ if (inheader->node[0] && clops->csid_from_name(csid, inheader->node)) { /* Error, node is not in the cluster */ - struct clvm_header reply; - DEBUGLOG("Unknown node: '%s'\n", inheader->node); + struct clvm_header reply = { + .cmd = CLVMD_CMD_REPLY, + .status = ENOENT + }; - reply.cmd = CLVMD_CMD_REPLY; - reply.status = ENOENT; - reply.flags = 0; - reply.arglen = 0; + DEBUGLOG("Unknown node: '%s'\n", inheader->node); send_message(&reply, sizeof(reply), our_csid, thisfd->fd, "Error sending ENOENT reply to local user"); @@ -1311,12 +1307,12 @@ /* Create a pipe and add the reading end to our FD list */ if (pipe(comms_pipe)) { - struct clvm_header reply; + struct clvm_header reply = { + .cmd = CLVMD_CMD_REPLY, + .status = EBUSY + }; + DEBUGLOG("creating pipe failed: %s\n", strerror(errno)); - reply.cmd = CLVMD_CMD_REPLY; - reply.status = EBUSY; - reply.arglen = 0; - reply.flags = 0; send_message(&reply, sizeof(reply), our_csid, thisfd->fd, "Error sending EBUSY reply to local user"); @@ -1325,14 +1321,14 @@ newfd = malloc(sizeof(struct local_client)); if (!newfd) { - struct clvm_header reply; + struct clvm_header reply = { + .cmd = CLVMD_CMD_REPLY, + .status = ENOMEM + }; + close(comms_pipe[0]); close(comms_pipe[1]); - reply.cmd = CLVMD_CMD_REPLY; - reply.status = ENOMEM; - reply.arglen = 0; - reply.flags = 0; send_message(&reply, sizeof(reply), our_csid, thisfd->fd, "Error sending ENOMEM reply to local user");
next reply other threads:[~2012-02-28 9:53 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-28 9:53 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-28 11:06 zkabelac 2012-02-28 9:58 zkabelac 2012-02-27 11:26 zkabelac 2012-02-27 9:58 zkabelac 2011-10-11 9:54 zkabelac 2011-10-11 9:26 zkabelac 2011-09-16 14:40 mbroz 2011-08-11 12:57 mbroz 2011-06-28 13:42 zkabelac 2011-03-30 12:36 zkabelac 2011-03-08 22:48 zkabelac 2011-03-08 13:27 mbroz 2010-12-13 10:49 prajnoha 2010-12-01 12:41 zkabelac 2010-12-01 10:46 zkabelac 2010-04-06 15:29 ccaulfield 2010-02-02 8:54 ccaulfield 2009-10-12 8:33 ccaulfield 2009-09-01 9:48 ccaulfield 2009-08-13 10:39 ccaulfield 2009-03-24 11:49 ccaulfield 2008-11-21 13:48 ccaulfield 2008-06-13 7:44 ccaulfield 2008-05-09 9:59 ccaulfield 2008-03-28 12:58 ccaulfield 2008-03-17 9:37 ccaulfield 2008-02-15 14:12 meyering 2007-11-15 10:16 pcaulfield 2007-03-29 13:59 pcaulfield 2006-12-11 13:48 pcaulfield 2006-11-30 9:44 pcaulfield 2005-04-01 13:01 pcaulfield 2005-02-08 9:05 pcaulfield 2005-01-24 15:31 pcaulfield 2005-01-05 14:41 pcaulfield 2004-10-06 12:36 pcaulfield 2004-10-06 10:12 pcaulfield
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120228095357.10415.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).