public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2/lib filters/filter.c format_text/format-t ...
@ 2012-02-28 10:11 zkabelac
0 siblings, 0 replies; only message in thread
From: zkabelac @ 2012-02-28 10:11 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2012-02-28 10:11:36
Modified files:
lib/filters : filter.c
lib/format_text: format-text.c
lib/metadata : metadata.c
Log message:
Add some stack traces for dev_close error paths
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/filters/filter.c.diff?cvsroot=lvm2&r1=1.69&r2=1.70
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/format-text.c.diff?cvsroot=lvm2&r1=1.196&r2=1.197
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.488&r2=1.489
--- LVM2/lib/filters/filter.c 2012/02/13 10:45:26 1.69
+++ LVM2/lib/filters/filter.c 2012/02/28 10:11:35 1.70
@@ -179,7 +179,8 @@
ret = 1;
out:
- dev_close(dev);
+ if (!dev_close(dev))
+ stack;
return ret;
}
--- LVM2/lib/format_text/format-text.c 2012/02/27 09:54:25 1.196
+++ LVM2/lib/format_text/format-text.c 2012/02/28 10:11:36 1.197
@@ -1357,8 +1357,10 @@
return_0;
if (!label_write(pv->dev, label)) {
- dev_close(pv->dev);
- return_0;
+ stack;
+ if (!dev_close(pv->dev))
+ stack;
+ return 0;
}
/*
--- LVM2/lib/metadata/metadata.c 2012/02/27 11:36:00 1.488
+++ LVM2/lib/metadata/metadata.c 2012/02/28 10:11:36 1.489
@@ -1460,10 +1460,12 @@
if (!dev_set(dev, UINT64_C(0), (size_t) 2048, 0)) {
log_error("%s not wiped: aborting", pv_name);
- dev_close(dev);
+ if (!dev_close(dev))
+ stack;
return 0;
}
- dev_close(dev);
+ if (!dev_close(dev))
+ stack;
}
log_error("Writing physical volume data to disk \"%s\"",
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-02-28 10:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-28 10:11 LVM2/lib filters/filter.c format_text/format-t zkabelac
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).