public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW_DM daemons/dmeventd/dmeventd.c Date: Thu, 01 Mar 2012 09:50:00 -0000 [thread overview] Message-ID: <20120301095005.30565.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-03-01 09:50:04 Modified files: . : WHATS_NEW_DM daemons/dmeventd: dmeventd.c Log message: Log fail of pthread_join Syslog error outside of mutex section. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.576&r2=1.577 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/dmeventd.c.diff?cvsroot=lvm2&r1=1.90&r2=1.91 --- LVM2/WHATS_NEW_DM 2012/02/28 17:47:24 1.576 +++ LVM2/WHATS_NEW_DM 2012/03/01 09:50:04 1.577 @@ -1,5 +1,6 @@ Version 1.02.73 - ==================================== + Log failure of pthread_join when cleaning unused threads in dmeventd. Fix empty string warning logic in _find_config_str. (1.02.68) Fix dm_task_set_name to properly resolve path to dm name (1.02.71). Add dm_strncpy() function as a faster strncpy() replacement. --- LVM2/daemons/dmeventd/dmeventd.c 2012/02/27 11:13:51 1.90 +++ LVM2/daemons/dmeventd/dmeventd.c 2012/03/01 09:50:04 1.91 @@ -1517,6 +1517,7 @@ int ret; struct dm_list *l; struct thread_status *thread; + int join_ret = 0; _lock_mutex(); while ((l = dm_list_first(&_thread_registry_unused))) { @@ -1556,12 +1557,15 @@ if (thread->status == DM_THREAD_DONE) { dm_list_del(l); - pthread_join(thread->thread, NULL); + join_ret = pthread_join(thread->thread, NULL); _free_thread_status(thread); } } _unlock_mutex(); + + if (join_ret) + syslog(LOG_ERR, "Failed pthread_join: %s\n", strerror(join_ret)); } static void _sig_alarm(int signum __attribute__((unused)))
next reply other threads:[~2012-03-01 9:50 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-01 9:50 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-24 12:25 zkabelac 2012-03-15 8:45 prajnoha 2012-03-14 11:16 prajnoha 2012-03-01 22:06 zkabelac 2011-07-28 13:06 prajnoha 2011-07-28 13:03 prajnoha
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120301095005.30565.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).