public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib/commands toolcontext.c
Date: Thu, 01 Mar 2012 21:16:00 -0000 [thread overview]
Message-ID: <20120301211605.9291.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2012-03-01 21:16:05
Modified files:
lib/commands : toolcontext.c
Log message:
Check for udev_get_dev_dir result
Don't use NULL return value.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.152&r2=1.153
--- LVM2/lib/commands/toolcontext.c 2012/02/27 10:05:35 1.152
+++ LVM2/lib/commands/toolcontext.c 2012/03/01 21:16:05 1.153
@@ -664,8 +664,9 @@
if ((device_list_from_udev = udev_is_running() ?
find_config_tree_bool(cmd, "devices/obtain_device_list_from_udev",
DEFAULT_OBTAIN_DEVICE_LIST_FROM_UDEV) : 0)) {
- udev_dir = udev_get_dev_dir();
- udev_dir_len = strlen(udev_dir);
+ if (!(udev_dir = udev_get_dev_dir()))
+ stack;
+ udev_dir_len = (udev_dir) ? strlen(udev_dir) : 0;
}
init_obtain_device_list_from_udev(device_list_from_udev);
@@ -687,7 +688,7 @@
return 0;
}
- if (device_list_from_udev) {
+ if (device_list_from_udev && udev_dir) {
len = strlen(cv->v.str);
len = udev_dir_len > len ? len : udev_dir_len;
if (strncmp(udev_dir, cv->v.str, len) ||
next reply other threads:[~2012-03-01 21:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:16 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-12 14:35 zkabelac
2012-02-08 13:44 zkabelac
2011-09-02 12:38 zkabelac
2011-07-08 17:31 agk
2011-04-29 16:23 agk
2010-12-20 14:34 zkabelac
2010-07-02 10:25 agk
2010-06-01 21:46 wysochanski
2009-07-08 18:12 wysochanski
2009-06-17 20:54 mbroz
2008-09-19 18:26 agk
2008-04-02 21:31 agk
2006-05-16 20:42 agk
2004-06-29 13:29 agk
2004-04-08 17:21 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301211605.9291.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).