public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW tools/lvcreate.c
Date: Thu, 01 Mar 2012 21:21:00 -0000 [thread overview]
Message-ID: <20120301212156.13159.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2012-03-01 21:21:55
Modified files:
. : WHATS_NEW
tools : lvcreate.c
Log message:
Check for alloc error
Simplify segtype_str usage and check for NULL segtype.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2330&r2=1.2331
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.257&r2=1.258
--- LVM2/WHATS_NEW 2012/03/01 10:39:21 1.2330
+++ LVM2/WHATS_NEW 2012/03/01 21:21:54 1.2331
@@ -1,5 +1,6 @@
Version 2.02.94 -
====================================
+ Check for alloc fail from get_segtype_from_string() in _lvcreate_params().
Add _rimage as reserved suffix to lvm.8 man page.
Improve error logging from mpath filter.
Check for allocation failure in hold_lock() in clvmd.
--- LVM2/tools/lvcreate.c 2012/02/28 14:24:58 1.257
+++ LVM2/tools/lvcreate.c 2012/03/01 21:21:55 1.258
@@ -652,10 +652,13 @@
else
segtype_str = "striped";
- lp->segtype = get_segtype_from_string(cmd, arg_str_value(cmd, type_ARG, segtype_str));
+ segtype_str = arg_str_value(cmd, type_ARG, segtype_str);
+
+ if (!(lp->segtype = get_segtype_from_string(cmd, segtype_str)))
+ return_0;
if (seg_unknown(lp)) {
- log_error("Unable to create LV with unknown segment type %s.", arg_str_value(cmd, type_ARG, segtype_str));
+ log_error("Unable to create LV with unknown segment type %s.", segtype_str);
return 0;
}
next reply other threads:[~2012-03-01 21:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:21 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-11 12:33 zkabelac
2012-03-02 17:25 zkabelac
2012-02-27 10:00 zkabelac
2011-11-07 11:01 zkabelac
2011-09-22 15:36 jbrassow
2008-09-24 16:32 mbroz
2008-06-05 13:38 agk
2008-01-17 15:53 agk
2008-01-16 15:25 agk
2007-11-12 13:34 agk
2007-09-24 13:25 wysochanski
2007-09-17 17:18 agk
2007-07-17 16:13 mbroz
2006-10-26 18:22 agk
2006-05-24 13:58 agk
2005-06-22 14:56 agk
2004-10-15 15:53 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301212156.13159.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).