public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2/tools pvremove.c
@ 2012-03-01 21:46 zkabelac
0 siblings, 0 replies; 3+ messages in thread
From: zkabelac @ 2012-03-01 21:46 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2012-03-01 21:46:31
Modified files:
tools : pvremove.c
Log message:
Replace goto with just log_debug
FIXME: temporal quick hack to make things green
There might be a better reaction.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.38&r2=1.39
--- LVM2/tools/pvremove.c 2012/02/28 18:08:08 1.38
+++ LVM2/tools/pvremove.c 2012/03/01 21:46:31 1.39
@@ -129,7 +129,7 @@
}
if (!lvmetad_pv_gone(dev->dev))
- goto_out;
+ log_debug("PV gone"); /* FIXME any better idea */
log_print("Labels on physical volume \"%s\" successfully wiped",
pv_name);
^ permalink raw reply [flat|nested] 3+ messages in thread* LVM2/tools pvremove.c
@ 2012-03-02 2:55 agk
0 siblings, 0 replies; 3+ messages in thread
From: agk @ 2012-03-02 2:55 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk@sourceware.org 2012-03-02 02:55:45
Modified files:
tools : pvremove.c
Log message:
Reinstate error if e.g. daemon comms fails.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.39&r2=1.40
--- LVM2/tools/pvremove.c 2012/03/01 21:46:31 1.39
+++ LVM2/tools/pvremove.c 2012/03/02 02:55:45 1.40
@@ -128,8 +128,9 @@
goto out;
}
+ /* FIXME Avoid error if we expect that daemon might not know device */
if (!lvmetad_pv_gone(dev->dev))
- log_debug("PV gone"); /* FIXME any better idea */
+ goto_out;
log_print("Labels on physical volume \"%s\" successfully wiped",
pv_name);
^ permalink raw reply [flat|nested] 3+ messages in thread* LVM2/tools pvremove.c
@ 2007-06-14 15:51 wysochanski
0 siblings, 0 replies; 3+ messages in thread
From: wysochanski @ 2007-06-14 15:51 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2007-06-14 15:51:36
Modified files:
tools : pvremove.c
Log message:
Fix inverted logic on last checkin for pvremove
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.15&r2=1.16
--- LVM2/tools/pvremove.c 2007/06/14 15:48:04 1.15
+++ LVM2/tools/pvremove.c 2007/06/14 15:51:36 1.16
@@ -43,7 +43,7 @@
}
/* orphan ? */
- if (!is_orphan(pv))
+ if (is_orphan(pv))
return 1;
/* Allow partial & exported VGs to be destroyed. */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-02 2:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-01 21:46 LVM2/tools pvremove.c zkabelac
-- strict thread matches above, loose matches on Subject: below --
2012-03-02 2:55 agk
2007-06-14 15:51 wysochanski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).