From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13518 invoked by alias); 1 Mar 2012 22:54:19 -0000 Received: (qmail 13496 invoked by uid 9737); 1 Mar 2012 22:54:18 -0000 Date: Thu, 01 Mar 2012 22:54:00 -0000 Message-ID: <20120301225418.13494.qmail@sourceware.org> From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/daemons/dmeventd dmeventd.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00030.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-03-01 22:54:17 Modified files: daemons/dmeventd: dmeventd.c Log message: Skip zero length messages In case of zero length message, there would be a memory leak on return path from _do_process_request. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/dmeventd.c.diff?cvsroot=lvm2&r1=1.93&r2=1.94 --- LVM2/daemons/dmeventd/dmeventd.c 2012/03/01 22:06:18 1.93 +++ LVM2/daemons/dmeventd/dmeventd.c 2012/03/01 22:54:17 1.94 @@ -1504,9 +1504,10 @@ while ((reg = _initial_registrations[i])) { msg.cmd = DM_EVENT_CMD_REGISTER_FOR_EVENT; - msg.size = strlen(reg); - msg.data = reg; - _do_process_request(&msg); + if ((msg.size = strlen(reg))) { + msg.data = reg; + _do_process_request(&msg); + } ++ i; } }