public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools polldaemon.c Date: Thu, 01 Mar 2012 23:20:00 -0000 [thread overview] Message-ID: <20120301232046.29671.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-03-01 23:20:46 Modified files: tools : polldaemon.c Log message: Check for error from dup2 Do not take correct fd as error result. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/polldaemon.c.diff?cvsroot=lvm2&r1=1.48&r2=1.49 --- LVM2/tools/polldaemon.c 2012/02/28 14:24:58 1.48 +++ LVM2/tools/polldaemon.c 2012/03/01 23:20:45 1.49 @@ -67,9 +67,9 @@ _exit(ECMD_FAILED); } - if (dup2(null_fd, STDIN_FILENO) || /* reopen stdin */ - dup2(null_fd, STDOUT_FILENO) || /* reopen stdout */ - dup2(null_fd, STDERR_FILENO)) { /* reopen stderr */ + if ((dup2(null_fd, STDIN_FILENO) < 0) || /* reopen stdin */ + (dup2(null_fd, STDOUT_FILENO) < 0) || /* reopen stdout */ + (dup2(null_fd, STDERR_FILENO) < 0)) { /* reopen stderr */ log_sys_error("dup2", "redirect"); (void) close(null_fd); _exit(ECMD_FAILED);
next reply other threads:[~2012-03-01 23:20 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-01 23:20 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-02-18 15:05 zkabelac 2009-07-01 17:05 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120301232046.29671.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).