From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-5253-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 29693 invoked by alias); 1 Mar 2012 23:20:47 -0000
Received: (qmail 29674 invoked by uid 9737); 1 Mar 2012 23:20:46 -0000
Date: Thu, 01 Mar 2012 23:20:00 -0000
Message-ID: <20120301232046.29671.qmail@sourceware.org>
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools polldaemon.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00032.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2012-03-01 23:20:46

Modified files:
	tools          : polldaemon.c 

Log message:
	Check for error from dup2
	
	Do not take correct fd as error result.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/polldaemon.c.diff?cvsroot=lvm2&r1=1.48&r2=1.49

--- LVM2/tools/polldaemon.c	2012/02/28 14:24:58	1.48
+++ LVM2/tools/polldaemon.c	2012/03/01 23:20:45	1.49
@@ -67,9 +67,9 @@
 		_exit(ECMD_FAILED);
 	}
 
-	if (dup2(null_fd, STDIN_FILENO)  || /* reopen stdin */
-	    dup2(null_fd, STDOUT_FILENO) || /* reopen stdout */
-	    dup2(null_fd, STDERR_FILENO)) { /* reopen stderr */
+	if ((dup2(null_fd, STDIN_FILENO) < 0)  || /* reopen stdin */
+	    (dup2(null_fd, STDOUT_FILENO) < 0) || /* reopen stdout */
+	    (dup2(null_fd, STDERR_FILENO) < 0)) { /* reopen stderr */
 		log_sys_error("dup2", "redirect");
 		(void) close(null_fd);
 		_exit(ECMD_FAILED);