From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-5255-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 4540 invoked by alias); 2 Mar 2012 02:55:47 -0000
Received: (qmail 4522 invoked by uid 9447); 2 Mar 2012 02:55:46 -0000
Date: Fri, 02 Mar 2012 02:55:00 -0000
Message-ID: <20120302025546.4520.qmail@sourceware.org>
From: agk@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools pvremove.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00034.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2012-03-02 02:55:45

Modified files:
	tools          : pvremove.c 

Log message:
	Reinstate error if e.g. daemon comms fails.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.39&r2=1.40

--- LVM2/tools/pvremove.c	2012/03/01 21:46:31	1.39
+++ LVM2/tools/pvremove.c	2012/03/02 02:55:45	1.40
@@ -128,8 +128,9 @@
 		goto out;
 	}
 
+	/* FIXME Avoid error if we expect that daemon might not know device */
 	if (!lvmetad_pv_gone(dev->dev))
-		log_debug("PV gone"); /* FIXME any better idea */
+		goto_out;
 
 	log_print("Labels on physical volume \"%s\" successfully wiped",
 		  pv_name);