public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/libdm libdm-deptree.c Date: Fri, 02 Mar 2012 21:53:00 -0000 [thread overview] Message-ID: <20120302215318.25431.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-03-02 21:53:17 Modified files: libdm : libdm-deptree.c Log message: Support 16GB for thin pool metadata Add some hack math to allow 16GB devices to be passed as thinpool metadata. Since kernel has put in limit to not allow which are just bigger then some predefined constant in kernel but not matching 16GB so any device bigger is rejected. FIXME: Current code still might need more tweaks to be more generic. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.160&r2=1.161 --- LVM2/libdm/libdm-deptree.c 2012/03/02 21:43:27 1.160 +++ LVM2/libdm/libdm-deptree.c 2012/03/02 21:53:17 1.161 @@ -2968,7 +2968,15 @@ uint64_t low_water_mark, unsigned skip_block_zeroing) { - struct load_segment *seg; + struct load_segment *seg, *mseg; + uint64_t devsize = 0; + /* + * Max supported size for thin pool metadata device + * Limitation is hardcoded into kernel and bigger + * device size is not accepted. (16978542592) + */ + const uint64_t max_metadata_size = + 255ULL * (1 << 14) * (4096 / (1 << 9)) - 256 * 1024; if (data_block_size < DM_THIN_MIN_DATA_BLOCK_SIZE) { log_error("Data block size %u is lower then %u sectors.", @@ -2993,6 +3001,18 @@ if (!_link_tree_nodes(node, seg->metadata)) return_0; + /* FIXME: more complex target may need more tweaks */ + dm_list_iterate_items(mseg, &seg->metadata->props.segs) { + devsize += mseg->size; + if (devsize > max_metadata_size) { + log_debug("Ignoring %" PRIu64 " of device.", + devsize - max_metadata_size); + mseg->size -= (devsize - max_metadata_size); + devsize = max_metadata_size; + /* FIXME: drop remaining segs */ + } + } + if (!(seg->pool = dm_tree_find_node_by_uuid(node->dtree, pool_uuid))) { log_error("Missing pool uuid %s.", pool_uuid); return 0;
next reply other threads:[~2012-03-02 21:53 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-02 21:53 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-15 20:03 agk 2012-05-15 14:10 agk 2012-03-04 16:05 zkabelac 2012-01-25 8:46 zkabelac 2012-01-19 15:22 zkabelac 2011-11-04 12:39 zkabelac 2011-10-30 22:04 zkabelac 2011-10-28 20:11 zkabelac 2011-10-20 10:39 zkabelac 2011-10-20 10:35 zkabelac 2011-10-19 16:45 zkabelac 2011-10-19 16:41 zkabelac 2011-10-17 14:15 zkabelac 2011-10-17 14:14 zkabelac 2011-10-03 18:29 zkabelac 2011-09-29 8:51 zkabelac 2011-07-08 19:13 agk 2011-06-22 12:56 prajnoha 2011-06-11 12:55 agk 2011-06-09 15:53 mbroz 2010-11-29 12:42 zkabelac 2010-11-29 11:26 zkabelac 2010-05-25 8:40 zkabelac 2010-04-07 23:51 agk 2010-04-07 21:25 agk 2010-01-15 16:00 jbrassow 2010-01-05 21:06 snitzer 2010-01-05 21:05 snitzer 2010-01-05 21:04 snitzer 2009-09-22 16:27 jbrassow 2009-07-07 16:36 agk 2008-12-12 18:45 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120302215318.25431.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).