From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25451 invoked by alias); 2 Mar 2012 21:53:18 -0000 Received: (qmail 25433 invoked by uid 9737); 2 Mar 2012 21:53:18 -0000 Date: Fri, 02 Mar 2012 21:53:00 -0000 Message-ID: <20120302215318.25431.qmail@sourceware.org> From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/libdm libdm-deptree.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00046.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-03-02 21:53:17 Modified files: libdm : libdm-deptree.c Log message: Support 16GB for thin pool metadata Add some hack math to allow 16GB devices to be passed as thinpool metadata. Since kernel has put in limit to not allow which are just bigger then some predefined constant in kernel but not matching 16GB so any device bigger is rejected. FIXME: Current code still might need more tweaks to be more generic. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.160&r2=1.161 --- LVM2/libdm/libdm-deptree.c 2012/03/02 21:43:27 1.160 +++ LVM2/libdm/libdm-deptree.c 2012/03/02 21:53:17 1.161 @@ -2968,7 +2968,15 @@ uint64_t low_water_mark, unsigned skip_block_zeroing) { - struct load_segment *seg; + struct load_segment *seg, *mseg; + uint64_t devsize = 0; + /* + * Max supported size for thin pool metadata device + * Limitation is hardcoded into kernel and bigger + * device size is not accepted. (16978542592) + */ + const uint64_t max_metadata_size = + 255ULL * (1 << 14) * (4096 / (1 << 9)) - 256 * 1024; if (data_block_size < DM_THIN_MIN_DATA_BLOCK_SIZE) { log_error("Data block size %u is lower then %u sectors.", @@ -2993,6 +3001,18 @@ if (!_link_tree_nodes(node, seg->metadata)) return_0; + /* FIXME: more complex target may need more tweaks */ + dm_list_iterate_items(mseg, &seg->metadata->props.segs) { + devsize += mseg->size; + if (devsize > max_metadata_size) { + log_debug("Ignoring %" PRIu64 " of device.", + devsize - max_metadata_size); + mseg->size -= (devsize - max_metadata_size); + devsize = max_metadata_size; + /* FIXME: drop remaining segs */ + } + } + if (!(seg->pool = dm_tree_find_node_by_uuid(node->dtree, pool_uuid))) { log_error("Missing pool uuid %s.", pool_uuid); return 0;