public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/activate/dev_manager.c Date: Mon, 05 Mar 2012 14:15:00 -0000 [thread overview] Message-ID: <20120305141551.13730.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-03-05 14:15:50 Modified files: . : WHATS_NEW lib/activate : dev_manager.c Log message: Improve warning Use thin_dump --repair suggestion in log error message and use just warning on deactivation path without repair info (since node has been deactivated). Also check whether there is not 16 args for thin_check configured. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2342&r2=1.2343 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/dev_manager.c.diff?cvsroot=lvm2&r1=1.273&r2=1.274 --- LVM2/WHATS_NEW 2012/03/05 14:12:57 1.2342 +++ LVM2/WHATS_NEW 2012/03/05 14:15:50 1.2343 @@ -1,5 +1,6 @@ Version 2.02.95 - ================================ + Print just warning on thin pool check callback path for failing check. Use 64bit math for verification of thin pool and snapshot chunk size. Validate udev structures in _insert_udev_dir(). Scan all devices for lvmetad if 'pvscan --cache' used without device list. --- LVM2/lib/activate/dev_manager.c 2012/03/02 21:49:44 1.273 +++ LVM2/lib/activate/dev_manager.c 2012/03/05 14:15:50 1.274 @@ -1231,15 +1231,28 @@ } args = dm_split_words(split, 16, 0, argv); + + if (args == 16) { + log_error("Too many options for thin check command."); + return 0; + } argv[args++] = meta_path; argv[args] = NULL; if (!(ret = exec_cmd(data->pool_lv->vg->cmd, (const char * const *)argv, &status, 0))) { - log_err_once("Check of thin pool %s/%s failed (status:%d). " - "Manual repair required (thin_repair %s)!", - data->pool_lv->vg->name, data->pool_lv->name, - status, meta_path); + switch (type) { + case DM_NODE_CALLBACK_PRELOADED: + log_err_once("Check of thin pool %s/%s failed (status:%d). " + "Manual repair required (thin_dump --repair %s)!", + data->pool_lv->vg->name, data->pool_lv->name, + status, meta_path); + break; + default: + log_warn("WARNING: Integrity check of metadata for thin pool " + "%s/%s failed.", + data->pool_lv->vg->name, data->pool_lv->name); + } /* * FIXME: What should we do here?? *
next reply other threads:[~2012-03-05 14:15 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-05 14:15 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-16 12:50 agk 2012-04-20 14:17 jbrassow 2012-02-01 13:47 zkabelac 2012-01-28 20:12 zkabelac 2012-01-23 20:56 jbrassow 2012-01-20 21:56 snitzer 2011-12-21 12:59 zkabelac 2011-11-18 19:42 zkabelac 2011-10-11 8:59 zkabelac 2011-10-11 8:57 zkabelac 2011-08-11 4:18 jbrassow 2011-07-06 0:29 agk 2011-07-05 23:10 agk 2011-01-05 14:03 zkabelac 2010-12-08 19:26 agk 2010-10-25 10:37 agk 2010-10-24 17:37 snitzer 2010-08-26 14:21 jbrassow 2010-08-17 1:51 agk 2010-08-03 13:13 zkabelac 2010-05-24 9:01 zkabelac 2010-05-21 14:48 zkabelac 2010-02-08 23:28 snitzer 2010-01-26 7:58 mbroz 2010-01-22 15:40 snitzer 2009-08-03 18:09 agk 2009-05-28 1:11 agk 2009-05-13 14:13 zkabelac 2008-12-19 15:23 mbroz 2008-06-05 12:45 agk 2007-05-14 11:27 mbroz 2007-03-08 19:58 agk 2006-11-20 16:45 agk 2006-07-10 19:17 agk 2005-10-18 12:39 agk 2005-08-04 1:27 agk 2005-08-04 1:15 agk 2004-05-12 20:43 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120305141551.13730.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).