public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/filters/filter.c Date: Tue, 20 Mar 2012 10:47:00 -0000 [thread overview] Message-ID: <20120320104703.6315.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-03-20 10:47:03 Modified files: . : WHATS_NEW lib/filters : filter.c Log message: Support improperly formated device numbers There are kernel drivers (smblk) which set '-1' as their device major number. This number is listed in /proc/devices then - but the kernel itself is using just 12 bits - thus device is accessible via 4095 - there is posted patch for 3.4 to fix this behavior (0 for auto allocation was mean to be used). However to still allow using such devices with older kernels add some code to use same behavior - so cut 12 bits from the major number from /proc/devices. For now use log_warn() - maybe the severity of the message could be lowered to just verbose level. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2359&r2=1.2360 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/filters/filter.c.diff?cvsroot=lvm2&r1=1.71&r2=1.72 --- LVM2/WHATS_NEW 2012/03/16 12:53:05 1.2359 +++ LVM2/WHATS_NEW 2012/03/20 10:47:02 1.2360 @@ -1,5 +1,6 @@ Version 2.02.96 - ================================ + Support improperly formated device numbers in /proc/devices (2.02.91). Fix fsadm propagation of -e option. Fix fsadm parsing of /proc/mounts files (don't check for substrings). Fix fsadm usage of arguments with space. --- LVM2/lib/filters/filter.c 2012/03/12 14:40:42 1.71 +++ LVM2/lib/filters/filter.c 2012/03/20 10:47:03 1.72 @@ -196,7 +196,7 @@ size_t dev_len = 0; const struct dm_config_value *cv; const char *name; - + char *nl; if (!*proc) { log_verbose("No proc filesystem found: using all block device " @@ -227,7 +227,20 @@ /* If it's not a number it may be name of section */ line_maj = atoi(((char *) (line + i))); - if ((line_maj <= 0) || (line_maj >= NUMBER_OF_MAJORS)) { + + if (line_maj < 0 || line_maj >= NUMBER_OF_MAJORS) { + /* + * Device numbers shown in /proc/devices are actually direct + * numbers passed to registering function, however the kernel + * uses only 12 bits, so use just 12 bits for major. + */ + if ((nl = strchr(line, '\n'))) *nl = '\0'; + log_warn("WARNING: /proc/devices line: %s, replacing major with %d.", + line, line_maj & (NUMBER_OF_MAJORS - 1)); + line_maj &= (NUMBER_OF_MAJORS - 1); + } + + if (!line_maj) { blocksection = (line[i] == 'B') ? 1 : 0; continue; }
next reply other threads:[~2012-03-20 10:47 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-20 10:47 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-08 12:48 zkabelac 2011-01-27 0:21 agk 2011-01-12 15:28 agk 2009-07-09 22:34 snitzer 2009-04-16 10:16 mbroz 2008-04-03 10:29 agk 2008-03-05 18:15 agk 2007-07-26 13:28 agk 2007-07-19 7:06 pcaulfield 2005-11-09 12:47 agk 2005-04-06 16:44 agk 2004-08-18 19:13 agk 2004-06-01 18:33 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120320104703.6315.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).