public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: jbrassow@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW daemons/dmeventd/plugins/lvm2 ...
Date: Tue, 10 Apr 2012 23:34:00 -0000	[thread overview]
Message-ID: <20120410233442.27068.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	jbrassow@sourceware.org	2012-04-10 23:34:41

Modified files:
	.              : WHATS_NEW 
	daemons/dmeventd/plugins/lvm2: dmeventd_lvm.c 

Log message:
	Commit ID 46a75dedb4f6aa815a804f27cafbd3fd16a62011 consolidated code from the
	various dmeventd plug-ins into a new function called 'dmeventd_lvm2_command',
	but the new function did not strip off the "_mlog" extentions that the
	mirror plug-in had been doing.  This created bug 794904 - failure to replace
	devices in a redundant log.
	
	The test suite did catch this scenario because it performs repair tests (mainly)
	through the CLI and not dmeventd.  It's also not easy to test because the test
	itself will hang if the bug is encountered.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2375&r2=1.2376
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c.diff?cvsroot=lvm2&r1=1.8&r2=1.9

--- LVM2/WHATS_NEW	2012/03/30 14:59:35	1.2375
+++ LVM2/WHATS_NEW	2012/04/10 23:34:41	1.2376
@@ -1,5 +1,6 @@
 Version 2.02.96 - 
 ================================
+  Fix ability to handle failures in mirrored log (regression intro 2.02.89).
   Fix unlocking volume group in vgreduce in error path.
   Exit immediately if LISTEN_PID env var incorrect during systemd handover.
   Detect VG name being part of the LV name in lvconvert --splitmirrors -n.
--- LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c	2012/02/01 20:11:58	1.8
+++ LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c	2012/04/10 23:34:41	1.9
@@ -160,6 +160,11 @@
 		return 0;
 	}
 
+	/* strip off the mirror component designations */
+	layer = strstr(lv, "_mlog");
+	if (layer)
+		*layer = '\0';
+
 	r = dm_snprintf(buffer, size, "%s %s/%s", cmd, vg, lv);
 
 	dm_pool_free(mem, vg);


             reply	other threads:[~2012-04-10 23:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 23:34 jbrassow [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-12-22 15:55 zkabelac
2010-09-30 11:40 zkabelac
2010-03-04  9:56 zkabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120410233442.27068.qmail@sourceware.org \
    --to=jbrassow@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).