public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2 ./WHATS_NEW daemons/dmeventd/plugins/lvm2 ...
@ 2012-04-10 23:34 jbrassow
  0 siblings, 0 replies; 4+ messages in thread
From: jbrassow @ 2012-04-10 23:34 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	jbrassow@sourceware.org	2012-04-10 23:34:41

Modified files:
	.              : WHATS_NEW 
	daemons/dmeventd/plugins/lvm2: dmeventd_lvm.c 

Log message:
	Commit ID 46a75dedb4f6aa815a804f27cafbd3fd16a62011 consolidated code from the
	various dmeventd plug-ins into a new function called 'dmeventd_lvm2_command',
	but the new function did not strip off the "_mlog" extentions that the
	mirror plug-in had been doing.  This created bug 794904 - failure to replace
	devices in a redundant log.
	
	The test suite did catch this scenario because it performs repair tests (mainly)
	through the CLI and not dmeventd.  It's also not easy to test because the test
	itself will hang if the bug is encountered.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2375&r2=1.2376
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c.diff?cvsroot=lvm2&r1=1.8&r2=1.9

--- LVM2/WHATS_NEW	2012/03/30 14:59:35	1.2375
+++ LVM2/WHATS_NEW	2012/04/10 23:34:41	1.2376
@@ -1,5 +1,6 @@
 Version 2.02.96 - 
 ================================
+  Fix ability to handle failures in mirrored log (regression intro 2.02.89).
   Fix unlocking volume group in vgreduce in error path.
   Exit immediately if LISTEN_PID env var incorrect during systemd handover.
   Detect VG name being part of the LV name in lvconvert --splitmirrors -n.
--- LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c	2012/02/01 20:11:58	1.8
+++ LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c	2012/04/10 23:34:41	1.9
@@ -160,6 +160,11 @@
 		return 0;
 	}
 
+	/* strip off the mirror component designations */
+	layer = strstr(lv, "_mlog");
+	if (layer)
+		*layer = '\0';
+
 	r = dm_snprintf(buffer, size, "%s %s/%s", cmd, vg, lv);
 
 	dm_pool_free(mem, vg);


^ permalink raw reply	[flat|nested] 4+ messages in thread

* LVM2 ./WHATS_NEW daemons/dmeventd/plugins/lvm2 ...
@ 2011-12-22 15:55 zkabelac
  0 siblings, 0 replies; 4+ messages in thread
From: zkabelac @ 2011-12-22 15:55 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-12-22 15:55:21

Modified files:
	.              : WHATS_NEW 
	daemons/dmeventd/plugins/lvm2: .exported_symbols dmeventd_lvm.c 
	                               dmeventd_lvm.h 

Log message:
	Add helper function dmeventd_lvm2_command().
	
	Since this code is in all plugins - create a common helper function.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2214&r2=1.2215
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/lvm2/.exported_symbols.diff?cvsroot=lvm2&r1=1.2&r2=1.3
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c.diff?cvsroot=lvm2&r1=1.6&r2=1.7
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.h.diff?cvsroot=lvm2&r1=1.1&r2=1.2

--- LVM2/WHATS_NEW	2011/12/22 15:50:38	1.2214
+++ LVM2/WHATS_NEW	2011/12/22 15:55:21	1.2215
@@ -1,5 +1,6 @@
 Version 2.02.89 - 
 ==================================
+  Add helper dmeventd_lvm2_command() into libdevmapper-event-lvm2 library.
   Updated documentation for dmeventd.
   Drop extra stat call before opening device.
   Reduce number of lstat calls when selecting device alias.
--- LVM2/daemons/dmeventd/plugins/lvm2/.exported_symbols	2010/01/22 12:38:16	1.2
+++ LVM2/daemons/dmeventd/plugins/lvm2/.exported_symbols	2011/12/22 15:55:21	1.3
@@ -4,3 +4,4 @@
 dmeventd_lvm2_unlock
 dmeventd_lvm2_pool
 dmeventd_lvm2_run
+dmeventd_lvm2_command
--- LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c	2011/10/19 08:46:26	1.6
+++ LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c	2011/12/22 15:55:21	1.7
@@ -151,3 +151,26 @@
 	return lvm2_run(_lvm_handle, cmdline);
 }
 
+int dmeventd_lvm2_command(struct dm_pool *mem, char *buffer, size_t size,
+			  const char *cmd, const char *device)
+{
+	char *vg = NULL, *lv = NULL, *layer;
+	int r;
+
+	if (!dm_split_lvm_name(mem, device, &vg, &lv, &layer)) {
+		syslog(LOG_ERR, "Unable to determine VG name from %s.\n",
+		       device);
+		return 0;
+	}
+
+	r = dm_snprintf(buffer, size, "%s %s/%s", cmd, vg, lv);
+
+	dm_pool_free(mem, vg);
+
+	if (r < 0) {
+		syslog(LOG_ERR, "Unable to form LVM command. (too long).\n");
+		return 0;
+	}
+
+	return 1;
+}
--- LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.h	2010/01/21 22:15:46	1.1
+++ LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.h	2011/12/22 15:55:21	1.2
@@ -36,4 +36,7 @@
 
 struct dm_pool *dmeventd_lvm2_pool(void);
 
+int dmeventd_lvm2_command(struct dm_pool *mem, char *buffer, size_t size,
+			  const char *cmd, const char *device);
+
 #endif /* _DMEVENTD_LVMWRAP_H */


^ permalink raw reply	[flat|nested] 4+ messages in thread

* LVM2 ./WHATS_NEW daemons/dmeventd/plugins/lvm2 ...
@ 2010-09-30 11:40 zkabelac
  0 siblings, 0 replies; 4+ messages in thread
From: zkabelac @ 2010-09-30 11:40 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-09-30 11:40:14

Modified files:
	.              : WHATS_NEW 
	daemons/dmeventd/plugins/lvm2: dmeventd_lvm.c 

Log message:
	Fix leaked pool report
	
	Swap pool destruction order in dmeventd_lvm2_exit() to fix leak report.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1739&r2=1.1740
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c.diff?cvsroot=lvm2&r1=1.4&r2=1.5

--- LVM2/WHATS_NEW	2010/09/30 11:32:40	1.1739
+++ LVM2/WHATS_NEW	2010/09/30 11:40:14	1.1740
@@ -1,5 +1,6 @@
 Version 2.02.75 - 
 =====================================
+  Swap pool destruction order in dmeventd_lvm2_exit() to fix leak report.
   Read whole /proc/self/maps file before working with maps entries.
   Speed up unquoting of quoted double quotes and backslashes.
   Speed up CRC32 calculations by using a larger lookup table.
--- LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c	2010/07/09 15:34:41	1.4
+++ LVM2/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c	2010/09/30 11:40:14	1.5
@@ -131,10 +131,10 @@
 
 	if (!--_register_count) {
 		lvm2_run(_lvm_handle, "_memlock_dec");
-		lvm2_exit(_lvm_handle);
-		_lvm_handle = NULL;
 		dm_pool_destroy(_mem_pool);
 		_mem_pool = NULL;
+		lvm2_exit(_lvm_handle);
+		_lvm_handle = NULL;
 	}
 
 	pthread_mutex_unlock(&_register_mutex);


^ permalink raw reply	[flat|nested] 4+ messages in thread

* LVM2 ./WHATS_NEW daemons/dmeventd/plugins/lvm2 ...
@ 2010-03-04  9:56 zkabelac
  0 siblings, 0 replies; 4+ messages in thread
From: zkabelac @ 2010-03-04  9:56 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-03-04 09:56:02

Modified files:
	.              : WHATS_NEW 
	daemons/dmeventd/plugins/lvm2: Makefile.in 
	daemons/dmeventd/plugins/mirror: Makefile.in 
	daemons/dmeventd/plugins/snapshot: Makefile.in 
	man            : Makefile.in 

Log message:
	Use consistently $() instead of ${} for all Makefile variables,
	thought both usage forms are correct.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1446&r2=1.1447
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/lvm2/Makefile.in.diff?cvsroot=lvm2&r1=1.1&r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/mirror/Makefile.in.diff?cvsroot=lvm2&r1=1.14&r2=1.15
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/plugins/snapshot/Makefile.in.diff?cvsroot=lvm2&r1=1.10&r2=1.11
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/man/Makefile.in.diff?cvsroot=lvm2&r1=1.31&r2=1.32

--- LVM2/WHATS_NEW	2010/03/04 09:53:08	1.1446
+++ LVM2/WHATS_NEW	2010/03/04 09:56:01	1.1447
@@ -1,5 +1,6 @@
 Version 2.02.62 -
 ====================================
+  Use consistently $() instead of ${} for all Makefile variables.
   Replace CFLOW_CMD only in make.tmpl and use it as variable elsewhere.
   Use $(top_builddir) for inclusion of make.tmpl in Makefiles.
   Fix autoconf warning about ignored datarootdir.
--- LVM2/daemons/dmeventd/plugins/lvm2/Makefile.in	2010/01/21 22:15:46	1.1
+++ LVM2/daemons/dmeventd/plugins/lvm2/Makefile.in	2010/03/04 09:56:01	1.2
@@ -16,7 +16,7 @@
 top_builddir = @top_builddir@
 VPATH = @srcdir@
 
-CLDFLAGS += -L${top_builddir}/tools
+CLDFLAGS += -L$(top_builddir)/tools
 
 SOURCES = dmeventd_lvm.c
 
--- LVM2/daemons/dmeventd/plugins/mirror/Makefile.in	2010/02/02 14:09:18	1.14
+++ LVM2/daemons/dmeventd/plugins/mirror/Makefile.in	2010/03/04 09:56:01	1.15
@@ -17,8 +17,8 @@
 top_builddir = @top_builddir@
 VPATH = @srcdir@
 
-INCLUDES += -I${top_srcdir}/tools -I$(top_srcdir)/daemons/dmeventd/plugins/lvm2
-CLDFLAGS += -L${top_builddir}/tools -L${top_builddir}/daemons/dmeventd/plugins/lvm2
+INCLUDES += -I$(top_srcdir)/tools -I$(top_srcdir)/daemons/dmeventd/plugins/lvm2
+CLDFLAGS += -L$(top_builddir)/tools -L$(top_builddir)/daemons/dmeventd/plugins/lvm2
 
 SOURCES = dmeventd_mirror.c
 
--- LVM2/daemons/dmeventd/plugins/snapshot/Makefile.in	2010/02/02 14:09:18	1.10
+++ LVM2/daemons/dmeventd/plugins/snapshot/Makefile.in	2010/03/04 09:56:01	1.11
@@ -17,8 +17,8 @@
 top_builddir = @top_builddir@
 VPATH = @srcdir@
 
-INCLUDES += -I${top_srcdir}/tools -I$(top_srcdir)/daemons/dmeventd/plugins/lvm2
-CLDFLAGS += -L${top_builddir}/tools -L${top_builddir}/daemons/dmeventd/plugins/lvm2
+INCLUDES += -I$(top_srcdir)/tools -I$(top_srcdir)/daemons/dmeventd/plugins/lvm2
+CLDFLAGS += -L$(top_builddir)/tools -L$(top_builddir)/daemons/dmeventd/plugins/lvm2
 
 SOURCES = dmeventd_snapshot.c
 
--- LVM2/man/Makefile.in	2010/03/04 09:51:40	1.31
+++ LVM2/man/Makefile.in	2010/03/04 09:56:01	1.32
@@ -43,8 +43,8 @@
 endif
 
 MAN8DM=dmsetup.8
-MAN5DIR=${mandir}/man5
-MAN8DIR=${mandir}/man8
+MAN5DIR=$(mandir)/man5
+MAN8DIR=$(mandir)/man8
 
 CLEAN_TARGETS=$(MAN5) $(MAN8) $(MAN8CLUSTER) $(FSADMMAN) $(MAN8DM)
 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-04-10 23:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-10 23:34 LVM2 ./WHATS_NEW daemons/dmeventd/plugins/lvm2 jbrassow
  -- strict thread matches above, loose matches on Subject: below --
2011-12-22 15:55 zkabelac
2010-09-30 11:40 zkabelac
2010-03-04  9:56 zkabelac

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).