public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: jbrassow@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW lib/metadata/vg.c
Date: Wed, 25 Apr 2012 13:38:00 -0000 [thread overview]
Message-ID: <20120425133844.2502.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: jbrassow@sourceware.org 2012-04-25 13:38:42
Modified files:
. : WHATS_NEW
lib/metadata : vg.c
Log message:
Disallow changing cluster attribute of VG while RAID LVs are active.
Mirror and snapshot LVs are already checked for when switching the cluster
attribute of a VG. This patch adds RAID.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2392&r2=1.2393
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/vg.c.diff?cvsroot=lvm2&r1=1.17&r2=1.18
--- LVM2/WHATS_NEW 2012/04/25 09:32:36 1.2392
+++ LVM2/WHATS_NEW 2012/04/25 13:38:41 1.2393
@@ -1,5 +1,6 @@
Version 2.02.96 -
================================
+ Disallow changing cluster attribute of VG while RAID LVs are active.
Fix lvconvert error message for non-mergeable volumes.
Allow subset of failed devices to be replaced in RAID LVs.
Prevent resume from creating error devices that already exist from suspend.
--- LVM2/lib/metadata/vg.c 2012/02/13 11:04:00 1.17
+++ LVM2/lib/metadata/vg.c 2012/04/25 13:38:42 1.18
@@ -517,9 +517,11 @@
* on active mirrors or snapshots.
*/
dm_list_iterate_items(lvl, &vg->lvs) {
- if (lv_is_mirrored(lvl->lv) && lv_is_active(lvl->lv)) {
- log_error("Mirror logical volumes must be inactive "
- "when changing the cluster attribute.");
+ if (lv_is_active(lvl->lv) &&
+ (lv_is_mirrored(lvl->lv) || lv_is_raid_type(lvl->lv))) {
+ log_error("%s logical volumes must be inactive "
+ "when changing the cluster attribute.",
+ lv_is_raid_type(lvl->lv) ? "RAID" : "Mirror");
return 0;
}
reply other threads:[~2012-04-25 13:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425133844.2502.qmail@sourceware.org \
--to=jbrassow@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).