From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2601 invoked by alias); 25 Apr 2012 13:38:45 -0000 Received: (qmail 2504 invoked by uid 9478); 25 Apr 2012 13:38:44 -0000 Date: Wed, 25 Apr 2012 13:38:00 -0000 Message-ID: <20120425133844.2502.qmail@sourceware.org> From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/vg.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00034.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2012-04-25 13:38:42 Modified files: . : WHATS_NEW lib/metadata : vg.c Log message: Disallow changing cluster attribute of VG while RAID LVs are active. Mirror and snapshot LVs are already checked for when switching the cluster attribute of a VG. This patch adds RAID. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2392&r2=1.2393 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/vg.c.diff?cvsroot=lvm2&r1=1.17&r2=1.18 --- LVM2/WHATS_NEW 2012/04/25 09:32:36 1.2392 +++ LVM2/WHATS_NEW 2012/04/25 13:38:41 1.2393 @@ -1,5 +1,6 @@ Version 2.02.96 - ================================ + Disallow changing cluster attribute of VG while RAID LVs are active. Fix lvconvert error message for non-mergeable volumes. Allow subset of failed devices to be replaced in RAID LVs. Prevent resume from creating error devices that already exist from suspend. --- LVM2/lib/metadata/vg.c 2012/02/13 11:04:00 1.17 +++ LVM2/lib/metadata/vg.c 2012/04/25 13:38:42 1.18 @@ -517,9 +517,11 @@ * on active mirrors or snapshots. */ dm_list_iterate_items(lvl, &vg->lvs) { - if (lv_is_mirrored(lvl->lv) && lv_is_active(lvl->lv)) { - log_error("Mirror logical volumes must be inactive " - "when changing the cluster attribute."); + if (lv_is_active(lvl->lv) && + (lv_is_mirrored(lvl->lv) || lv_is_raid_type(lvl->lv))) { + log_error("%s logical volumes must be inactive " + "when changing the cluster attribute.", + lv_is_raid_type(lvl->lv) ? "RAID" : "Mirror"); return 0; }