public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/commands/toolcontext.c Date: Wed, 23 May 2012 13:02:00 -0000 [thread overview] Message-ID: <20120523130237.506.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-05-23 13:02:37 Modified files: . : WHATS_NEW lib/commands : toolcontext.c Log message: Fix error path Do not increase nr_filt in case of NULL ret value, since the error path doesn't handle NULL pointers. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2408&r2=1.2409 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.156&r2=1.157 --- LVM2/WHATS_NEW 2012/05/16 13:09:09 1.2408 +++ LVM2/WHATS_NEW 2012/05/23 13:02:36 1.2409 @@ -1,5 +1,6 @@ Version 2.02.96 - ================================ + Fix error paths for regex filter initialization. Re-enable partial activation of non-thin LVs until it can be fixed. (2.02.90) Fix alloc cling to cling to PVs already found with contiguous policy. Fix cling policy not to behave like normal policy if no previous LV seg. --- LVM2/lib/commands/toolcontext.c 2012/03/23 09:42:36 1.156 +++ LVM2/lib/commands/toolcontext.c 2012/05/23 13:02:37 1.157 @@ -759,17 +759,19 @@ log_very_verbose("devices/filter not found in config file: " "no regex filter installed"); - else if (!(filters[nr_filt++] = regex_filter_create(cn->v))) { + else if (!(filters[nr_filt] = regex_filter_create(cn->v))) { log_error("Failed to create regex device filter"); goto bad; - } + } else + nr_filt++; /* device type filter. Required. */ cn = find_config_tree_node(cmd, "devices/types"); - if (!(filters[nr_filt++] = lvm_type_filter_create(cmd->proc_dir, cn))) { + if (!(filters[nr_filt] = lvm_type_filter_create(cmd->proc_dir, cn))) { log_error("Failed to create lvm type filter"); goto bad; } + nr_filt++; /* md component filter. Optional, non-critical. */ if (find_config_tree_bool(cmd, "devices/md_component_detection",
next reply other threads:[~2012-05-23 13:02 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-05-23 13:02 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-23 9:42 zkabelac 2012-02-27 10:05 zkabelac 2012-02-08 10:46 zkabelac 2011-07-08 16:49 agk 2011-06-28 0:23 agk 2010-11-24 9:34 zkabelac 2010-04-30 12:37 zkabelac 2009-07-21 20:00 mpatocka 2009-07-14 12:17 mbroz 2009-06-15 11:56 mbroz 2009-04-02 20:46 taka 2007-02-08 17:31 agk 2007-01-23 16:03 agk 2005-01-27 15:50 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120523130237.506.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).